Rewrite the primary Pod Topology Spread Constraints based on label selector#806
Merged
stefanprodan merged 3 commits intofluxcd:mainfrom Feb 13, 2021
Merged
Conversation
Nerja
force-pushed
the
fixedspreadconstraintssuffixes
branch
from
2cd6c58 to
b41a270
Compare
Codecov Report
@@ Coverage Diff @@
## main #806 +/- ##
==========================================
- Coverage 56.83% 56.81% -0.03%
==========================================
Files 67 67
Lines 5417 5418 +1
==========================================
- Hits 3079 3078 -1
- Misses 1879 1881 +2
Partials 459 459
Continue to review full report at Codecov.
|
Member
|
Hi @Nerja can you please update https://github.com/fluxcd/flagger/blob/main/docs/gitbook/faq.md#is-pod-affinity-and-anti-affinity-supported to reflect your latest changes and add topology to it? Thanks |
Added unit test assertions Changed comment Signed-off-by: Marcus Rodan <marcus.rodan@sinch.com>
Signed-off-by: Marcus Rodan <marcus.rodan@sinch.com>
Signed-off-by: Marcus Rodan <marcus.rodan@sinch.com>
Nerja
force-pushed
the
fixedspreadconstraintssuffixes
branch
from
83a582d to
76b73a6
Compare
Contributor
Author
|
@stefanprodan Found a moment during my vacation to add some info to the FAQ. Please have a look and let me know if we need to add more information. |
stefanprodan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds rewrites of label selector values for Pod Topology Spread Constraints, similar to what we already have for PodAntiAffinity.
Fix: #801