add support to hpa behaviors on canaries#740
Merged
stefanprodan merged 2 commits intofluxcd:masterfrom Dec 7, 2020
Merged
Conversation
stefanprodan
requested changes
Dec 6, 2020
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
Please change the HPAs used in unit tests to v2beta2.
stefanprodan
approved these changes
Dec 7, 2020
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @tr-fteixeira
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #727
I've tested the client locally agains a 1.14 (kind) and it was alright.. If there is no behavior, it is just ignored.
Didn't fully test a deployment/canary rollout on that version.
Tested it all against a 1.18 cluster, deployment and changes to HPA specs are synced correctly.
HPA is not tracked by itself, depends on changes on other resources to be applied to primary.
The logs for diff in behavior fields