fine-grained rbac for flagger helm#73
Conversation
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=======================================
Coverage 54.53% 54.53%
=======================================
Files 13 13
Lines 1533 1533
=======================================
Hits 836 836
Misses 557 557
Partials 140 140Continue to review full report at Codecov.
|
charts/flagger/templates/rbac.yaml
Outdated
| - list | ||
| - watch | ||
| - nonResourceURLs: | ||
| - /version?timeout=32s |
There was a problem hiding this comment.
Do we need the timeout arg? Would it work with /version only?
| - "" | ||
| resources: | ||
| - services | ||
| verbs: |
There was a problem hiding this comment.
We'll need patch and update to cover future work.
| - autoscaling | ||
| resources: | ||
| - horizontalpodautoscalers | ||
| verbs: |
There was a problem hiding this comment.
We'll need patch and update to cover future work.
|
@huydinhle thanks for this. Please apply the same RBAC setting in here also https://github.com/stefanprodan/flagger/blob/master/artifacts/flagger/account.yaml |
huydinhle
force-pushed
the
fined-grained-rbac
branch
2 times, most recently
from
1b99f3f to
2b6507d
Compare
|
addressed all the comments @stefanprodan |
3 participants
@stefanprodan took a stab at this #48
I generated using
audit2rbacand tested by running the tutorials to make sure no rbac problems showed upFix: #48