Add support for Istio VirtualService delegation#715
Add support for Istio VirtualService delegation#715stefanprodan merged 12 commits intofluxcd:masterfrom
Conversation
9df3a64 to
a335ea2
Compare
|
@kazukousen should we add some test in |
|
@mathetake i see, later i will try adding test. |
|
In addition to unit testing, i have added e2e testing to ensure that the CRD is actually behaving correctly and delegating as expected. its test want to switch enable/disable to pilot env My idea is to keep the number of replicas to 1 by adding the If you can accept this, I will try it. |
|
@kazukousen you could also patch istiod and set the memory and cpu requests super low. I am ok with whatever works. Thanks |
Co-authored-by: Takeshi Yoneda <yoneda.takeshi.md@alumni.tsukuba.ac.jp>
|
with the istiod cpu and memory requests set low, it works. |
|
Please update istio in e2e to a version that supports delegation. I guess that’s the reason validation fails. |
|
@stefanprodan |
|
@kazukousen can you please undo the kustomization change and use https://istio.io/latest/docs/ops/integrations/prometheus/ in e2e tests. |
265f4f0 to
50b513a
Compare
|
the failed test |
Co-authored-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @kazukousen 🏅
the Istio provider now supports VIrtualService delegate.
https://istio.io/latest/docs/reference/config/networking/virtual-service/#Delegate
for example, if rootVS and delegateVS are there, the VirtualService which Flagger creates can achieve to behave as delegateVS.
it might related #673 .
for that, the Hosts and Gateways must accept an empty to be applied as a delegateVS.