Add New Relic as a metrics provider#691
Merged
stefanprodan merged 5 commits intofluxcd:masterfrom Sep 17, 2020
Merged
Conversation
fpetkovski
force-pushed
the
newrelic-provider
branch
from
6cc5d56 to
04dd365
Compare
fpetkovski
force-pushed
the
newrelic-provider
branch
2 times, most recently
from
e3598c3 to
ab28006
Compare
fpetkovski
force-pushed
the
newrelic-provider
branch
from
ab28006 to
2c249e2
Compare
stefanprodan
reviewed
Sep 9, 2020
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
@fpetkovski can you please add a "New Relic" section to the docs https://github.com/weaveworks/flagger/blob/master/docs/gitbook/usage/metrics.md
fpetkovski
commented
Sep 9, 2020
Contributor
Author
fpetkovski
left a comment
fpetkovski
left a comment
There was a problem hiding this comment.
Accept suggested changes
Co-authored-by: Stefan Prodan <stefan.prodan@gmail.com>
mathetake
approved these changes
Sep 9, 2020
Contributor
Author
Thanks for the pointer, will add the section with the proposed queries and get back to you |
fpetkovski
force-pushed
the
newrelic-provider
branch
from
f130523 to
c81e19c
Compare
fpetkovski
force-pushed
the
newrelic-provider
branch
from
2da2268 to
563b1cd
Compare
Co-authored-by: Stefan Prodan <stefan.prodan@gmail.com>
fpetkovski
commented
Sep 10, 2020
stefanprodan
approved these changes
Sep 10, 2020
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @fpetkovski 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull requests adds New Relic as an available metrics provider. The implementation follows the one from the datadog provider.