Skipper: preserve Predicates#681
Merged
stefanprodan merged 1 commit intofluxcd:masterfrom Aug 29, 2020
Merged
Conversation
Current implementation did overwrite potentially existing Predicates. We face the situation that we need to add further Predicates which we need to keep in order to have a proper route setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation did overwrite potentially existing Predicates.
However, there are situations where other
Predicatesneed to be set on the same annotation which need to be kept in order to have a proper route setup.These changes have been tested in EKS clusters