pkg/canary/daemonset: fix ready condition according to kubectl#529
Merged
pkg/canary/daemonset: fix ready condition according to kubectl#529
Conversation
mathetake
commented
Mar 27, 2020
| github.com/aws/aws-sdk-go v1.29.29 | ||
| github.com/davecgh/go-spew v1.1.1 | ||
| github.com/google/go-cmp v0.4.0 | ||
| github.com/pkg/errors v0.9.1 |
Collaborator
Author
There was a problem hiding this comment.
I think this is something to do with finalizer #495 (I am going to refactor in another PR
Member
There was a problem hiding this comment.
I think we should run go mod tidy in CI and fail the build if go.mod changes to prevent things like this in the future.
stefanprodan
approved these changes
Mar 27, 2020
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @mathetake 🎖
Collaborator
Author
|
thanks 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not sure but hope this will solve #525
fixed
isDaemonSetReadyfunction according to kubectl's official implementation