loadtester: add concord test support#507
Merged
stefanprodan merged 1 commit intofluxcd:masterfrom Mar 19, 2020
Merged
Conversation
Member
|
@ernst01 thanks for the PR, can you please document the webhook here https://github.com/weaveworks/flagger/blob/master/docs/gitbook/usage/webhooks.md#integration-testing Thanks |
8691cff to
7f590b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Here's a PR for Concord support in Flagger's loadtester.
Fix: #477
Example query
Example logs
Regarding Authentication
This implementation requires to have a Concord API key present in a file directly on the container. This can be done via mounting a k8s secret in the Loadtester's Deployment.
I went with a file over an environment variable since it's arguably more secured. Happy to switch if you think necessary.
Let me know what you think so far,
Best,