Feat: Add Support for Cookie Attributes in Session Affinity#1826
Feat: Add Support for Cookie Attributes in Session Affinity#1826stefanprodan merged 5 commits intofluxcd:mainfrom
Conversation
|
@stefanprodan @aryan9600 Any thoughts? |
Signed-off-by: Renato Vassão <renato.vassao@mindbodyonline.com>
Signed-off-by: Renato Vassão <renato.vassao@mindbodyonline.com>
Signed-off-by: Renato Vassão <renato.vassao@mindbodyonline.com>
Signed-off-by: Renato Vassão <renato.vassao@mindbodyonline.com>
b67d81d to
0dd9fe9
Compare
There was a problem hiding this comment.
Can you please update the docs with all new fields here: https://docs.flagger.app/usage/deployment-strategies#canary-release-with-session-affinity
The source is here: https://github.com/fluxcd/flagger/blob/main/docs/gitbook/usage/deployment-strategies.md#configuring-stickiness-for-primary-deployment
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1826 +/- ##
===========================================
- Coverage 39.44% 28.91% -10.54%
===========================================
Files 287 287
Lines 22706 22909 +203
===========================================
- Hits 8956 6623 -2333
- Misses 12777 15561 +2784
+ Partials 973 725 -248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Renato Vassão <renato.vassao@mindbodyonline.com>
5e873a8 to
fab4540
Compare
|
Thanks for the review @stefanprodan, updated docs with new functionality. |
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @renatovassaomb
Summary
Adding support for specifying all cookie attributes to Session Affinity except
Expires, which doesn't look like it would be useful.Fixes #1527
Changes
Testing
References