Add Checksum field to the Webhook payload to distinguish canary runs #1521
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom Sep 19, 2023
bigkevmcd:hook-versions
Merged
Add Checksum field to the Webhook payload to distinguish canary runs #1521stefanprodan merged 1 commit intofluxcd:mainfrom bigkevmcd:hook-versions
stefanprodan merged 1 commit intofluxcd:mainfrom
bigkevmcd:hook-versions
Conversation
stefanprodan
added
the
kind/enhancement
This adds a new Checksum field to the canary webhook body, which is a hash of the LastAppliedSpec and TrackedConfigs. This can be used to identify the rollout of a specific configuration, and differentiate between webhooks being sent for different configuration and deployment versions. Signed-off-by: Kevin McDermott <[email protected]>
stefanprodan
changed the title
stefanprodan
approved these changes
Sep 19, 2023
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @bigkevmcd 🏅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new Checksum field to the canary webhook body, which is a hash of the LastAppliedSpec and TrackedConfigs.
This can be used to identify the rollout of a specific configuration, and differentiate between webhooks being sent for different configuration and deployment versions.