Skip to content

Update Istio Gateway reference format#1489

Merged
aryan9600 merged 1 commit intofluxcd:mainfrom
sonbui00:fix-1104
Aug 28, 2023
Merged

Update Istio Gateway reference format#1489
aryan9600 merged 1 commit intofluxcd:mainfrom
sonbui00:fix-1104

Conversation

@sonbui00
Copy link
Contributor

Update format for istio gateways

Fix #1104

Tested:

  • make test
  • e2e-test job with provider istio v1.15, v1.18 (v1.14 does not support my arm64)

@sonbui00 sonbui00 marked this pull request as ready for review August 28, 2023 11:23
@sonbui00 sonbui00 requested a review from stefanprodan as a code owner August 28, 2023 11:23
@stefanprodan stefanprodan changed the title fix: Incorrect format for istio gateways #1104 Update Istio Gateway reference format Aug 28, 2023
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @sonbui00 🥇

Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! could you please rebase on top of main?

Signed-off-by: Son Bui <sonbv00@gmail.com>
@sonbui00
Copy link
Contributor Author

lgtm! could you please rebase on top of main?

I've made the rebase @aryan9600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect format for istio gateways in docs

3 participants