Helm: Allow custom labels for servicemonitor#1483
Merged
aryan9600 merged 1 commit intofluxcd:mainfrom Aug 28, 2023
tyagian:helm_chart_fix
Merged
Helm: Allow custom labels for servicemonitor#1483aryan9600 merged 1 commit intofluxcd:mainfrom tyagian:helm_chart_fix
aryan9600 merged 1 commit intofluxcd:mainfrom
tyagian:helm_chart_fix
Conversation
Contributor
Author
|
@stefanprodan updated values.yaml and readme.md |
Signed-off-by: Anuj Tyagi <tyagi.an@husky.neu.edu>
stefanprodan
approved these changes
Aug 28, 2023
stefanprodan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Servicemonitor require label additions based to match with prometheus labels for sending metrics.
So, when we enable servicemonitor https://github.com/fluxcd/flagger/blob/main/charts/flagger/values.yaml#L28
this MR will add labels added under servicemonitor.
serviceMonitor: enabled: true labels: prometheus: appIf Prometheus need labels to match in servicemonitor, this change is useful.