Skip to content

Add support for istio LEAST_REQUEST destination rule load balancing#1439

Merged
aryan9600 merged 1 commit intofluxcd:mainfrom
Codasquieves:main
Jul 7, 2023
Merged

Add support for istio LEAST_REQUEST destination rule load balancing#1439
aryan9600 merged 1 commit intofluxcd:mainfrom
Codasquieves:main

Conversation

@Codasquieves
Copy link
Contributor

Istio will deprecate LEAST_CONN option of destination rule load balancing algorithms and LEAST_REQUEST type is being used instead of LEAST_CONN.

istio code

@stefanprodan
Copy link
Member

Please run make codegen and make fmt.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @Codasquieves please squash the two commits and force push.

@aryan9600
Copy link
Member

sorry to leave this unattended, @Codasquieves could you please rebase against main? we'll be ready to merge then :)

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (2b80c47) 54.52% compared to head (18e6afa) 54.54%.

❗ Current head 18e6afa differs from pull request most recent head 7d29af4. Consider uploading reports for the commit 7d29af4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1439      +/-   ##
==========================================
+ Coverage   54.52%   54.54%   +0.02%     
==========================================
  Files          84       84              
  Lines       10142    10140       -2     
==========================================
+ Hits         5530     5531       +1     
+ Misses       3955     3953       -2     
+ Partials      657      656       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aryan9600
Copy link
Member

@Codasquieves we prefer rebases over merge :)

…lgorithm

Signed-off-by: Ivan Lopes <ivanckp@gmail.com>
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Codasquieves 🎖️

@aryan9600 aryan9600 merged commit 6d6fc94 into fluxcd:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants