Fix panic when annotation of ingress is empty#1437
Merged
aryan9600 merged 1 commit intofluxcd:mainfrom May 30, 2023
Merged
Conversation
pinkavaj
force-pushed
the
pi-fix-nil
branch
2 times, most recently
from
b9f030f to
a1d0ed0
Compare
When the annotation of ingress is not set, the returned value is nil (not empty map). Trying to assign to this map leads to panic. Signed-off-by: Jiří Pinkava <j-pi@seznam.cz>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1437 +/- ##
==========================================
- Coverage 54.54% 54.52% -0.03%
==========================================
Files 84 84
Lines 10140 10142 +2
==========================================
- Hits 5531 5530 -1
- Misses 3953 3955 +2
- Partials 656 657 +1
☔ View full report in Codecov by Sentry. |
aryan9600
approved these changes
May 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the annotation of ingress is not set, the returned value is nil (not empty map). Trying to assign to this map leads to panic.
Closes #1277