Helm: Add option to create service and serviceMonitor#1425
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom May 11, 2023
ML-ZoneReaper:main
Merged
Helm: Add option to create service and serviceMonitor#1425stefanprodan merged 1 commit intofluxcd:mainfrom ML-ZoneReaper:main
stefanprodan merged 1 commit intofluxcd:mainfrom
ML-ZoneReaper:main
Conversation
ML-ZoneReaper
changed the title
charts/flagger/values.yaml
Outdated
Comment on lines
+26
to
+29
| # creates service for 'http' port | ||
| service: | ||
| enabled: false | ||
| port: 8080 |
Member
There was a problem hiding this comment.
Let's delete this and create the service only when serviceMonitor is enabled
Member
There was a problem hiding this comment.
Please add serviceMonitor to the chart readme, then squash all your commits into a single one.
Signed-off-by: Eugene Bykov <44170496+eabykov@users.noreply.github.com> Update README.md Signed-off-by: Eugene Bykov <44170496+eabykov@users.noreply.github.com> Update values.yaml Signed-off-by: Eugene Bykov <44170496+eabykov@users.noreply.github.com> Update service.yaml Signed-off-by: Eugene Bykov <44170496+eabykov@users.noreply.github.com> Update values.yaml Signed-off-by: Eugene Bykov <44170496+eabykov@users.noreply.github.com> Update service.yaml Signed-off-by: Eugene Bykov <44170496+eabykov@users.noreply.github.com> Create servicemonitor.yaml Signed-off-by: Eugene Bykov <44170496+eabykov@users.noreply.github.com> Update service.yaml Signed-off-by: Eugene Bykov <44170496+eabykov@users.noreply.github.com> Create service.yaml Signed-off-by: Eugene Bykov <44170496+eabykov@users.noreply.github.com>
stefanprodan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases when annotation auto-discovery is disabled in the Prometheus configuration we need to add an ability to collect metrics from flagger using
service+serviceMonitorresourcesLook how we can use flagger metrics with Grafana Dashboard: