Skip to content

Add app.kubernetes.io/version label to chart#1264

Merged
aryan9600 merged 1 commit intofluxcd:mainfrom
glindstedt:patch-1
Sep 1, 2022
Merged

Add app.kubernetes.io/version label to chart#1264
aryan9600 merged 1 commit intofluxcd:mainfrom
glindstedt:patch-1

Conversation

@glindstedt
Copy link
Contributor

Add app.kubernetes.io/version label as described in https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

This is useful if you have many deployments in different clusters and want to be able to monitor what versions you have deployed using something like kube_pod_labels from kube-state-metrics.

Signed-off-by: Gustaf Lindstedt gustaf.lindstedt@embark-studios.com

Add `app.kubernetes.io/version` label as described in https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

This is useful if you have many deployments in different clusters and want to be able to monitor what versions you have deployed using something like `kube_pod_labels` from kube-state-metrics.

Signed-off-by: Gustaf Lindstedt <gustaf.lindstedt@embark-studios.com>
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @glindstedt 🏅

@aryan9600
Copy link
Member

@glindstedt I noticed from your commit sig that you work at Embark Studios? If Emabrk Studios uses Flagger, could you please add yourself as an adopter? That'd be really helpful for the project, thanks! :D

@aryan9600 aryan9600 merged commit 89b0487 into fluxcd:main Sep 1, 2022
@glindstedt
Copy link
Contributor Author

@aryan9600 sure thing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants