fix contour prom query for when service name is overwritten#1204
Merged
aryan9600 merged 1 commit intofluxcd:mainfrom Jun 21, 2022
Merged
fix contour prom query for when service name is overwritten#1204aryan9600 merged 1 commit intofluxcd:mainfrom
aryan9600 merged 1 commit intofluxcd:mainfrom
Conversation
BrandonCate
force-pushed
the
contour-service-metric-fix
branch
from
2fa5d61 to
d2623bc
Compare
aryan9600
requested changes
May 26, 2022
Member
|
I'd imagine this problem exists with all other providers that use Envoy, like Kuma, Gloo, etc. If you'd be willing to modify this PR to fix and test those as well, that'd be great 😄 |
BrandonCate
force-pushed
the
contour-service-metric-fix
branch
from
72a343a to
84cbca9
Compare
Contributor
Author
|
@aryan9600 updated with suggestions |
aryan9600
approved these changes
Jun 16, 2022
Member
aryan9600
left a comment
aryan9600
left a comment
There was a problem hiding this comment.
Could you please squash all three commits into one with the message fix contour prom query when service name is specified. Thanks!
Signed-off-by: brandoncate <brandon.cate@shipt.com>
BrandonCate
force-pushed
the
contour-service-metric-fix
branch
from
84cbca9 to
e1bd004
Compare
Contributor
Author
|
squashed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When the Canary.Spec.Service.Name field is used to override default generated name the corresponding prom queries fail to return anything during the canary analysis phase due to an incorrect envoy_cluster_name
Fix:
The envoy_cluster_name is based off of the service name and so the service name is used instead of the target name (targetRef.Name)
Note:
Unsure if this is a similar problem for all envoy based controllers