Add flag to disable cross namespace refs to Custom Resources#1181
Merged
stefanprodan merged 3 commits intofluxcd:mainfrom May 3, 2022
Merged
Add flag to disable cross namespace refs to Custom Resources#1181stefanprodan merged 3 commits intofluxcd:mainfrom
stefanprodan merged 3 commits intofluxcd:mainfrom
Conversation
…Templates Signed-off-by: Sanskar Jaiswal <[email protected]>
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
Please add this flag to the Helm chart and document what it does in the chart readme.
stefanprodan
added
the
kind/enhancement
Codecov Report
@@ Coverage Diff @@
## main #1181 +/- ##
==========================================
+ Coverage 56.78% 56.91% +0.13%
==========================================
Files 79 79
Lines 6622 6631 +9
==========================================
+ Hits 3760 3774 +14
+ Misses 2304 2301 -3
+ Partials 558 556 -2
Continue to review full report at Codecov.
|
stefanprodan
approved these changes
Apr 29, 2022
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @aryan9600 please reword the last commit to "Add cross-namespace refs to FAQ".
added 2 commits
April 29, 2022 13:50
Signed-off-by: Sanskar Jaiswal <[email protected]>
Signed-off-by: Sanskar Jaiswal <[email protected]>
aryan9600
force-pushed
the
no-cross-ns-refs
branch
from
d0a26b9 to
30ed9fb
Compare
aryan9600
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sanskar Jaiswal [email protected]