Fix canary rollback behaviour#1171
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom Apr 15, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1171 +/- ##
==========================================
- Coverage 56.81% 56.78% -0.04%
==========================================
Files 79 79
Lines 6616 6622 +6
==========================================
+ Hits 3759 3760 +1
- Misses 2301 2304 +3
- Partials 556 558 +2
Continue to review full report at Codecov.
|
Prevents the canary from getting triggered, when a canary deploy is updated to match the primary deploy after an analysis fails. Signed-off-by: Sanskar Jaiswal <[email protected]>
aryan9600
force-pushed
the
fix-primary-restart
branch
from
1635732 to
c7c0c76
Compare
stefanprodan
approved these changes
Apr 15, 2022
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @aryan9600 🏅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents the canary from getting triggered, when a canary deploy is
updated to match the primary deploy after an analysis fails.
Fixes: #1163
Signed-off-by: Sanskar Jaiswal [email protected]