Update metadata during subsequent promote#1092
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom Feb 7, 2022
Merged
Conversation
Member
|
Hi @kh34 can you please signoff your commit and properly format your commit message and PR name/description. Thanks |
Codecov Report
@@ Coverage Diff @@
## main #1092 +/- ##
==========================================
- Coverage 57.29% 57.29% -0.01%
==========================================
Files 78 78
Lines 6304 6343 +39
==========================================
+ Hits 3612 3634 +22
- Misses 2154 2168 +14
- Partials 538 541 +3
Continue to review full report at Codecov.
|
Contributor
Author
Hi @stefanprodan I updated the PR. Thanks for reviewing. |
8a13814 to
0aa9eee
Compare
Signed-off-by: Karl Heins <karlheins@northwesternmutual.com> Support updating primary Deployment/DaemonSet/HPA/Service labels and annotations after first-time rollout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support updating primary Deployment/DaemonSet/HPA/Service labels and annotations after first-time rollout
Implements #1032, refactor of #1042 as per https://cloud-native.slack.com/archives/C01JR4YUG4B/p1635952858039600
Fix: #1032