Skip to content

Add kuma support for progressive traffic shifting canaries#1085

Merged
stefanprodan merged 11 commits intofluxcd:mainfrom
johnharris85:add-kuma-support
Jan 11, 2022
Merged

Add kuma support for progressive traffic shifting canaries#1085
stefanprodan merged 11 commits intofluxcd:mainfrom
johnharris85:add-kuma-support

Conversation

@johnharris85
Copy link
Contributor

This PR adds support for Kuma service mesh to Flagger.

  • All unit tests pass
  • All e2e tests pass
  • Docs added

Currently only canaries are supported, but I'm planning to add A/B testing in another PR when I get around to it.

Signed-off-by: John Harris <[email protected]>
Signed-off-by: John Harris <[email protected]>
Signed-off-by: John Harris <[email protected]>
Signed-off-by: John Harris <[email protected]>
Signed-off-by: John Harris <[email protected]>
Signed-off-by: John Harris <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #1085 (d203869) into main (ebc26e9) will increase coverage by 0.12%.
The diff coverage is 62.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
+ Coverage   57.23%   57.36%   +0.12%     
==========================================
  Files          76       78       +2     
  Lines        6162     6297     +135     
==========================================
+ Hits         3527     3612      +85     
- Misses       2105     2148      +43     
- Partials      530      537       +7     
Impacted Files Coverage Δ
pkg/metrics/observers/factory.go 0.00% <0.00%> (ø)
pkg/router/factory.go 0.00% <0.00%> (ø)
pkg/metrics/observers/kuma.go 46.66% <46.66%> (ø)
pkg/router/kuma.go 70.27% <70.27%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc26e9...d203869. Read the comment docs.

@stefanprodan stefanprodan added the kind/feature Feature request label Jan 5, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you @johnharris85 🏅

"github.com/fluxcd/flagger/pkg/metrics/providers"
)

// TODO [@johnharris85]: Do we also need to select by mesh here? These could be duplicated (but in different meshes).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think duplication is possible since the metric refers to a service by name and namespace which are unique per cluster. Can you add the same service to two Kuma meshes?

Signed-off-by: John Harris <[email protected]>
@stefanprodan stefanprodan changed the title Add kuma support Add kuma support for progressive traffic shifting canaries Jan 6, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @johnharris85 🥇

@johnharris85
Copy link
Contributor Author

Awesome, thanks for the review! I almost have blue-green finished too so if we can get this merged I'll throw that up later this week :)

@stefanprodan stefanprodan merged commit 96d190a into fluxcd:main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants