Add kuma support for progressive traffic shifting canaries#1085
Add kuma support for progressive traffic shifting canaries#1085stefanprodan merged 11 commits intofluxcd:mainfrom
Conversation
Signed-off-by: John Harris <[email protected]>
Signed-off-by: John Harris <[email protected]>
Signed-off-by: John Harris <[email protected]>
Signed-off-by: John Harris <[email protected]>
Signed-off-by: John Harris <[email protected]>
Signed-off-by: John Harris <[email protected]>
Signed-off-by: John Harris <[email protected]>
Signed-off-by: John Harris <[email protected]>
Signed-off-by: John Harris <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1085 +/- ##
==========================================
+ Coverage 57.23% 57.36% +0.12%
==========================================
Files 76 78 +2
Lines 6162 6297 +135
==========================================
+ Hits 3527 3612 +85
- Misses 2105 2148 +43
- Partials 530 537 +7
Continue to review full report at Codecov.
|
stefanprodan
left a comment
There was a problem hiding this comment.
This looks great, thank you @johnharris85 🏅
| "github.com/fluxcd/flagger/pkg/metrics/providers" | ||
| ) | ||
|
|
||
| // TODO [@johnharris85]: Do we also need to select by mesh here? These could be duplicated (but in different meshes). |
There was a problem hiding this comment.
I don't think duplication is possible since the metric refers to a service by name and namespace which are unique per cluster. Can you add the same service to two Kuma meshes?
Signed-off-by: John Harris <[email protected]>
Signed-off-by: John Harris <[email protected]>
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @johnharris85 🥇
|
Awesome, thanks for the review! I almost have blue-green finished too so if we can get this merged I'll throw that up later this week :) |
This PR adds support for Kuma service mesh to Flagger.
Currently only canaries are supported, but I'm planning to add A/B testing in another PR when I get around to it.