Skip to content

Add support for Istio load balancer settings#1016

Merged
stefanprodan merged 1 commit intofluxcd:mainfrom
somtochiama:istio-crds
Sep 17, 2021
Merged

Add support for Istio load balancer settings#1016
stefanprodan merged 1 commit intofluxcd:mainfrom
somtochiama:istio-crds

Conversation

@somtochiama
Copy link
Member

@somtochiama somtochiama commented Sep 16, 2021

Closes #997
Closes #996

Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com

@somtochiama somtochiama marked this pull request as ready for review September 17, 2021 08:04
@stefanprodan stefanprodan changed the title Update loadbalancer settings Add support for Istio load balancer settings Sep 17, 2021
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1016 (4fe2679) into main (b57d393) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 4fe2679 differs from pull request most recent head 5245045. Consider uploading reports for the commit 5245045 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1016      +/-   ##
==========================================
- Coverage   56.95%   56.85%   -0.10%     
==========================================
  Files          76       75       -1     
  Lines        6093     6024      -69     
==========================================
- Hits         3470     3425      -45     
+ Misses       2098     2086      -12     
+ Partials      525      513      -12     
Impacted Files Coverage Δ
pkg/canary/config_tracker.go 83.40% <0.00%> (-0.90%) ⬇️
pkg/controller/scheduler_metrics.go 35.44% <0.00%> (-0.34%) ⬇️
pkg/metrics/providers/factory.go 0.00% <0.00%> (ø)
pkg/metrics/providers/dynatrace.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b57d393...5245045. Read the comment docs.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama

@stefanprodan stefanprodan merged commit e8b1740 into fluxcd:main Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants