Open
Conversation
|
Hi @MarkOSullivan94! When you have some free time, would you be able to take a look at this MR? It'd be awesome to have Linux support! |
|
+1 to adding this. Would love to see it supported so I don't have to use a workaround. Please let me know if I can help if you need a tester or anything. |
|
@MarkOSullivan94 are there any Plans for this in the foreseeable Future ? Would really make the Package have Full Platform coverage instead of having to manually set the Icon in the .cc file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #629
This PR adds Linux support for flutter_launcher_icons (Setting the window icon)
I also added a whole bunch of tests to cover different edge cases as we are manipulating code that the user could have changed already.