Skip to content

Conversation

@parlough
Copy link
Member

@parlough parlough commented Nov 17, 2022

See main differences in site-shared PR (dart-lang/site-shared#163).

  • Update to latest compatible versions of diff2html and highlightjs without larger changes
  • Add integrity checking to the scripts
  • Remove jquery usage with modern (and faster) built-in methods
  • Fixes error caused by jquery not being present yet sometimes

After:
After diff2html example

Before:
Before diff2html example

Issues fixed by this PR (if any): Fixes N/A

Presubmit checklist

@parlough parlough added the review.tech Awaiting Technical Review label Nov 17, 2022
@parlough parlough merged commit 81da98c into flutter:main Nov 17, 2022
@parlough parlough deleted the misc/update-diff2html branch November 17, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review.tech Awaiting Technical Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants