-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Adding Apple frameworks > flutter plugins doc #7747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jmagman and @hellohuanlin in case you would like to take a look |
| the package in your Dart file. | ||
|
|
||
| Occasionally, you may also need to change app settings or | ||
| initialization logic- which will be explained in the package's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's initialization logic? do you mean app delegate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes exactly
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits. You know, it strikes me that this page would be well suited to be a 3-column table with a "Swift/Objective-C column, a Flutter column, and a Comments column. It would greatly reduce a lot of boilerplate text.
atsansone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leighajarett : I have some suggestions here. After you revise, I'll have another look.
Co-authored-by: Anthony Sansone <[email protected]> Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Anthony Sansone <[email protected]>
|
I like the idea of using a table for this doc, is there an example in our docs that you could send over so I can adapt it? Also, I want to be clear that this is not a doc for 1P plugins. It references plugins that are also 3P. I only included plugins that are widely used by the community. But I am happy to include a sentence in this doc somewhere that says something like "some of the plugins referenced in this doc are built and maintained by members of the Flutter community" to make it clear (or some language are the idea that this is not an endorsement). Let me know what you think! |
|
we may also wanna include database, which is pretty common: https://docs.flutter.dev/cookbook/persistence/sqlite can mention native uses either |
|
I've changed some of the wording based on feedback around the title / description. I also added the "persisting data" piece (following @hellohuanlin's input on SQLite) and added a sentence saying we're not endorsing packages listed (feel free to propose a better way to message this). As a quick aside, I've only included 3P plugins that have high scores on pub. Last, I also formatted it as a table, as suggested by @atsansone. But, it could use some formatting :) |
hellohuanlin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Table for the win
|
Thanks for the formatting, looks good to me! Is there anyone else that needs to review @atsansone? |
Description of what this PR is changing or adding, and why: This PR creates a new document in the iOS platform integration section which maps commonly used Apple frameworks to Flutter plugins / dart pacakges. We often see questions like "Can I use XXXKit in a Flutter app?" -- this document seeks to help iOS developers quickly get started with Flutter and answer those types of questions.
Issues fixed by this PR (if any): Fixes #7572
Presubmit checklist