Skip to content

Conversation

@leighajarett
Copy link
Contributor

Description of what this PR is changing or adding, and why: This PR creates a new document in the iOS platform integration section which maps commonly used Apple frameworks to Flutter plugins / dart pacakges. We often see questions like "Can I use XXXKit in a Flutter app?" -- this document seeks to help iOS developers quickly get started with Flutter and answer those types of questions.

Issues fixed by this PR (if any): Fixes #7572

Presubmit checklist

@leighajarett
Copy link
Contributor Author

@jmagman and @hellohuanlin in case you would like to take a look

@atsansone atsansone added the review.copy Awaiting Copy Review label Nov 10, 2022
the package in your Dart file.

Occasionally, you may also need to change app settings or
initialization logic- which will be explained in the package's
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's initialization logic? do you mean app delegate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes exactly

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits. You know, it strikes me that this page would be well suited to be a 3-column table with a "Swift/Objective-C column, a Flutter column, and a Comments column. It would greatly reduce a lot of boilerplate text.

@atsansone atsansone changed the title Adding apple framewokrs > flutter plugins doc Adding Apple frameworks > flutter plugins doc Nov 13, 2022
Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leighajarett : I have some suggestions here. After you revise, I'll have another look.

@atsansone atsansone added review.await-update Awaiting Updates after Edits and removed review.copy Awaiting Copy Review labels Nov 13, 2022
leighajarett and others added 2 commits November 14, 2022 10:46
Co-authored-by: Anthony Sansone <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
@leighajarett
Copy link
Contributor Author

I like the idea of using a table for this doc, is there an example in our docs that you could send over so I can adapt it?

Also, I want to be clear that this is not a doc for 1P plugins. It references plugins that are also 3P. I only included plugins that are widely used by the community. But I am happy to include a sentence in this doc somewhere that says something like "some of the plugins referenced in this doc are built and maintained by members of the Flutter community" to make it clear (or some language are the idea that this is not an endorsement). Let me know what you think!

@sfshaza2 @atsansone

@hellohuanlin
Copy link
Contributor

we may also wanna include database, which is pretty common: https://docs.flutter.dev/cookbook/persistence/sqlite

can mention native uses either CoreData or sqlite, and flutter use this plugin

@leighajarett
Copy link
Contributor Author

I've changed some of the wording based on feedback around the title / description. I also added the "persisting data" piece (following @hellohuanlin's input on SQLite) and added a sentence saying we're not endorsing packages listed (feel free to propose a better way to message this). As a quick aside, I've only included 3P plugins that have high scores on pub.

Last, I also formatted it as a table, as suggested by @atsansone. But, it could use some formatting :)

Copy link
Contributor

@hellohuanlin hellohuanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table for the win

@leighajarett leighajarett removed the review.await-update Awaiting Updates after Edits label Nov 17, 2022
@leighajarett leighajarett added the review.copy Awaiting Copy Review label Nov 17, 2022
@leighajarett
Copy link
Contributor Author

Thanks for the formatting, looks good to me! Is there anyone else that needs to review @atsansone?

@atsansone atsansone added st.RFM Ready to merge or land and removed review.copy Awaiting Copy Review labels Nov 18, 2022
@atsansone atsansone merged commit 9051327 into main Nov 18, 2022
@atsansone atsansone deleted the appleframeworks branch November 18, 2022 19:33
@sfshaza2 sfshaza2 removed the st.RFM Ready to merge or land label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a page that maps Apple Kit's to workflows on Flutter

5 participants