-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add release notes for DevTools 2.52.0 #12652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @elliette, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the official release notes for DevTools version 2.52.0. It documents a range of updates, including general user interface improvements for data tables, several bug fixes and enhancements for the network profiler, and a critical fix for keyboard shortcuts when DevTools is used within VS Code on macOS. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the release notes for DevTools version 2.52.0. My review focuses on improving the formatting and consistency of the release notes document. I've identified a broken link to a pull request and several formatting inconsistencies in the list of changes. I've provided specific suggestions to correct the link and standardize the formatting for better readability.
src/content/tools/devtools/release-notes/release-notes-2.52.0.md
Outdated
Show resolved
Hide resolved
| * Fixed layout of the "error count" badge in the tab name. - | ||
| [#9470](https://github.com/flutter/devtools/pull/9470) | ||
| * Fixed display of "Response Headers" and "Request Headers" when there are no | ||
| headers. - [#9492](https://github.com/flutter/devtools/pull/9492) | ||
| * Added a banner to clearly indicate when DevTools is not logging network | ||
| requests. - [#9495](https://github.com/flutter/devtools/pull/9495) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list items in this section have some formatting inconsistencies:
- They use
*as a marker, while other sections use-. For consistency, it's better to use-. - The formatting with a trailing
-and inconsistent newlines for links can be simplified.
I suggest the following changes for consistency and readability:
| * Fixed layout of the "error count" badge in the tab name. - | |
| [#9470](https://github.com/flutter/devtools/pull/9470) | |
| * Fixed display of "Response Headers" and "Request Headers" when there are no | |
| headers. - [#9492](https://github.com/flutter/devtools/pull/9492) | |
| * Added a banner to clearly indicate when DevTools is not logging network | |
| requests. - [#9495](https://github.com/flutter/devtools/pull/9495) | |
| - Fixed layout of the "error count" badge in the tab name. [#9470](https://github.com/flutter/devtools/pull/9470) | |
| - Fixed display of "Response Headers" and "Request Headers" when there are no | |
| headers. [#9492](https://github.com/flutter/devtools/pull/9492) | |
| - Added a banner to clearly indicate when DevTools is not logging network | |
| requests. [#9495](https://github.com/flutter/devtools/pull/9495) |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally don't edit an autogenerated release notes page. lgtm
|
/gcbrun |
|
@elliette, can you fix the broken build? thx! |
|
Visit the preview URL for this PR (updated for commit 2f77d1d): https://flutter-docs-prod--pr12652-devtools-release-notes-2-52-3bbb8c0u.web.app |
No description provided.