Skip to content

Conversation

@Navil
Copy link
Contributor

@Navil Navil commented Feb 7, 2025

This pull request fixes the problem where the color picker wasn't handling hex values correctly.

Image
Old:
Image
New:
image

Fixes #2577

@kevmoo
Copy link
Contributor

kevmoo commented Feb 13, 2025

also please rebase to get this running on CI! 😄

@kevmoo
Copy link
Contributor

kevmoo commented Feb 13, 2025

I got you! 😄

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2025
@auto-submit
Copy link

auto-submit bot commented Feb 13, 2025

autosubmit label was removed for flutter/samples/2578, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 2 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2025
@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2025
@auto-submit
Copy link

auto-submit bot commented Feb 13, 2025

autosubmit label was removed for flutter/samples/2578, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@kevmoo kevmoo requested a review from domesticmouse February 13, 2025 03:47
@kevmoo
Copy link
Contributor

kevmoo commented Feb 13, 2025

@domesticmouse would you review, approve, and do the auto-submit dance 🙏

@kevmoo kevmoo merged commit 3ae8c20 into flutter:main Feb 13, 2025
13 checks passed
@kevmoo
Copy link
Contributor

kevmoo commented Feb 13, 2025

@Navil Navil deleted the fix_material_3_demo_color_picker branch February 13, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[material_3_demo] Color picker not working since Flutter 3.26+

2 participants