Skip to content

[compass_app] Don't expose Dimens subclasses #2541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

[compass_app] Don't expose Dimens subclasses #2541

merged 1 commit into from
Dec 5, 2024

Conversation

@parlough
Copy link
Member

@parlough parlough commented Dec 5, 2024

Avoid exposing the subclasses as they shouldn't be instantiated again or overridden.

Also consistently use fields and getters in the declarations.

miquelbeltran
miquelbeltran approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks!

@ericwindmill ericwindmill merged commit 5adcda3 into main Dec 5, 2024
13 checks passed
@ericwindmill ericwindmill deleted the misc/compass-app-dimens branch December 5, 2024 13:39
@reidbaker reidbaker mentioned this pull request Feb 13, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

@miquelbeltran miquelbeltran miquelbeltran approved these changes

@ericwindmill ericwindmill Awaiting requested review from ericwindmill

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@parlough @domesticmouse @miquelbeltran @ericwindmill