Skip to content

Conversation

@QuncCccccc
Copy link
Contributor

This PR is to include CarouselView to M3 demo app.

flutter_3_24.mov

Pre-launch Checklist

  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I read the [Contributors Guide].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this will be held until 3.24 is stable?

/cc @ericwindmill

@domesticmouse
Copy link
Contributor

Also, I'm curious why master channel is flailing. Also, the CI is failing to load. Wha?

@ericwindmill
Copy link
Collaborator

I'm assuming this will be held until 3.24 is stable?

/cc @ericwindmill

Yes, I'm holding because this is the only update for 3.24

@@ -0,0 +1,80 @@
#!/bin/bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this because I'm treating this PR as the Flutter 3.24 update branch

@ericwindmill ericwindmill changed the title Add CarouselView examples to demo 3 Flutter 3.24 update, Add CarouselView examples to demo 3 Aug 6, 2024
@ericwindmill ericwindmill merged commit 2fc80aa into main Aug 6, 2024
@ericwindmill ericwindmill deleted the add_carousel_m3_demo branch August 6, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants