[image_picker] add resize quality #855

katout · 2018-10-17T11:47:28Z

The image size is very large in the current implementation.
I added items that can set jpeg's quality

e.g.

ImagePicker.pickImage(
  source: ImageSource.camera,
  maxWidth: maxWidth,
  maxHeight: maxHeight,
  resizeQuality: resizeQuality,
)

katout · 2018-10-19T02:25:01Z

I'm sorry
The quality setting of ios is incorrect.

I will fix it when I get home.

katout · 2018-10-19T12:48:06Z

ok!

nosmirck · 2018-10-26T18:43:12Z

hello @katout

I'm about to make a PR on your branch, please take a look, I didn't change anything really, mostly got rid of the unnecessary changes (gradle and other android files) plus one minor change in the ImageResizer to get the quality before passing it to the method and another in the dart file to validate that the resizeQuality passed is between 0.0 and 1.0

[EDIT]
Apparently I can't make a PR into your branch. Any suggestions? my branch is this one:

https://github.com/nosmirck/plugins/tree/add_quality

nosmirck · 2018-10-26T19:26:32Z

packages/cloud_firestore/android/build.gradle

 }

-allprojects {
+rootProject.allprojects {


unnecessary change

We prob don't need this.

nosmirck

I added some comments requesting a few changes.

nosmirck · 2018-10-26T19:26:39Z

packages/image_picker/android/build.gradle

    repositories {
        google()
        jcenter()
+        mavenLocal()


unnecessary change

don't need this

nosmirck · 2018-10-26T19:27:00Z

packages/image_picker/android/build.gradle


    dependencies {
-        classpath 'com.android.tools.build:gradle:3.1.2'
+        classpath 'com.android.tools.build:gradle:3.2.0'


unnecessary change

nosmirck · 2018-10-26T19:27:04Z

packages/image_picker/android/build.gradle

    repositories {
        google()
        jcenter()
+        mavenLocal()


unnecessary change

nosmirck · 2018-10-26T19:28:02Z

packages/image_picker/android/src/main/java/io/flutter/plugins/imagepicker/ImageResizer.java

    boolean shouldDownscaleHeight = hasMaxHeight && maxHeight < originalHeight;
    boolean shouldDownscale = shouldDownscaleWidth || shouldDownscaleHeight;

+    resizeQuality = resizeQuality != null ? resizeQuality : new Double(1.0);


int quality = resizeQuality != null ? ((int) resizeQuality * 100.0) : 100;

nosmirck · 2018-10-26T19:28:37Z

packages/image_picker/android/src/main/java/io/flutter/plugins/imagepicker/ImageResizer.java

    Bitmap scaledBmp = Bitmap.createScaledBitmap(bmp, width.intValue(), height.intValue(), false);
    ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
-    scaledBmp.compress(Bitmap.CompressFormat.JPEG, 100, outputStream);
+    scaledBmp.compress(Bitmap.CompressFormat.JPEG, (int) (resizeQuality * 100), outputStream);


scaledBmp.compress(Bitmap.CompressFormat.JPEG, quality, outputStream);

nosmirck · 2018-10-26T19:29:09Z

packages/image_picker/example/android/build.gradle

    repositories {
        google()
        jcenter()
+        mavenLocal()


unnecessary change

nosmirck · 2018-10-26T19:29:13Z

packages/image_picker/example/android/build.gradle


    dependencies {
-        classpath 'com.android.tools.build:gradle:3.1.2'
+        classpath 'com.android.tools.build:gradle:3.2.0'


unnecessary change

nosmirck · 2018-10-26T19:29:18Z

packages/image_picker/example/android/build.gradle

    repositories {
        google()
        jcenter()
+        mavenLocal()


unnecessary change

nosmirck · 2018-10-26T19:29:23Z

packages/image_picker/example/android/gradle/wrapper/gradle-wrapper.properties

 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-4.6-all.zip


unnecessary change

nosmirck · 2018-10-26T19:31:52Z

packages/image_picker/lib/image_picker.dart

+    double resizeQuality,
  }) async {
    assert(source != null);



check for value between 0.0 and 1.0

if (resizeQuality != null && (resizeQuality < 0 || resizeQuality > 1.0)) { throw ArgumentError.value(resizeQuality, 'resizeQuality must be between 0.0 and 1.0'); }

katout · 2018-10-28T10:32:50Z

Hi @nosmirck !
Thank you for checking 👍

check for value between 0.0 and 1.0

I thought that libraries of android and ios would check that, but I think so too.

unnecessary change

Certainly, it should be fixed with another PR rather than this PR.
I compiled it into one for the local test to be successful...
I would like the maintainer to decide whether it is acceptable.

katout · 2018-10-28T10:38:13Z

If @nosmirck threw a pull request to katout, please create another branch from https: //github.com/katout/plugins/tree/add_quality (different from add_quality )and request katout / plugins.

I am sorry, git and English are not good 🤕

nosmirck · 2018-10-29T13:35:59Z

If @nosmirck threw a pull request to katout, please create another branch from https: //github.com/katout/plugins/tree/add_quality (different from add_quality )and request katout / plugins.

I am sorry, git and English are not good 🤕

I tried creating a PR to your repo, but apparently your repo is not accepting PRs (or maybe I did something wrong).

You might as well try to pull my branch, delete your image_picker folder inside your branch and replace with mine (is the same thing plus the fixes I added).

Also, if you give me access to your fork, I might just push my changes too.

katout · 2018-10-30T01:31:39Z

I think that it is because you are running fork with flutter/plugins instead of katout/plugins.
and I see Your branch (nosmirck/plugins) history derived, not a derived branch from katout/plugins.
Sorry if different 😢

Please do your best because the modifications should remain in the history

nosmirck · 2018-10-30T02:00:49Z

@katout I managed to do it! I had to delete my old fork and fork again from yours, branch from your branch and add my changes.

The PR is there and awaiting :)

It has been a pleasure working with you XD

# Conflicts: # packages/image_picker/example/android/gradle/wrapper/gradle-wrapper.properties

cyanglaz

Sorry for the late response.
The image_picker has been updated a lot since this PR and there seems to be conflicts, do you mind to rebase and resolve the conflicts? Note that we added a type check for the images; so on IOS, you might need to handle the case that PNG and GIF doesn't support qualities.

cyanglaz · 2019-04-17T18:22:16Z

packages/cloud_firestore/android/build.gradle

 }

-allprojects {
+rootProject.allprojects {


We prob don't need this.

cyanglaz · 2019-04-17T18:22:24Z

packages/image_picker/android/build.gradle

    repositories {
        google()
        jcenter()
+        mavenLocal()


don't need this

katout · 2019-07-12T13:11:24Z

Sorry, I have no motivation to maintain it because it is too old.
Please close this issue as it looks like a little while reading the code.

cyanglaz · 2019-07-12T16:22:36Z

@katout Thank you for the quick response. I do think what the PR is trying to do is valuable. It isn't trivial to merge right now. I'm following the initial PR review policy, I'm labeling it with "backlog" and we will prioritize according to the issue's priority.

The issue is created here flutter/flutter#36072

cyanglaz · 2019-08-05T17:41:26Z

This feature has been added in #1896
Closing this PR.

add resize quality

3f49787

googlebot added the cla: yes label Oct 17, 2018

katout added 3 commits October 18, 2018 01:52

run format & test

1682aa7

manual format

916d151

edit test

4efbe5a

katout changed the title ~~add resize quality~~ [image_picker] add resize quality Oct 18, 2018

update build settings

4d39878

jpeg quality setting by ios

b3d78fc

nosmirck reviewed Oct 26, 2018

View reviewed changes

nosmirck suggested changes Oct 26, 2018

View reviewed changes

Merge commit '5b45f58ccab7009d473d6c767e9e40ddcabedde3' into add_quality

782cdd8

# Conflicts: # packages/image_picker/example/android/gradle/wrapper/gradle-wrapper.properties

katout mentioned this pull request Nov 5, 2018

[image_picker] original file is leaking by resize. #887

Closed

collinjackson added the feature label Dec 12, 2018

Merge branch 'master' into add_quality

21c24ca

cyanglaz suggested changes Jul 8, 2019

View reviewed changes

cyanglaz mentioned this pull request Jul 12, 2019

image picker should be able to return a lower resolution JPEG flutter/flutter#36072

Closed

cyanglaz added the backlog label Jul 12, 2019

cyanglaz closed this Aug 5, 2019

[image_picker] add resize quality #855

[image_picker] add resize quality #855

Uh oh!

Conversation

katout commented Oct 17, 2018

Uh oh!

katout commented Oct 19, 2018

Uh oh!

katout commented Oct 19, 2018

Uh oh!

nosmirck commented Oct 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nosmirck left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

katout commented Oct 28, 2018

Uh oh!

katout commented Oct 28, 2018

Uh oh!

nosmirck commented Oct 29, 2018

Uh oh!

katout commented Oct 30, 2018

Uh oh!

nosmirck commented Oct 30, 2018

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

katout commented Jul 12, 2019

Uh oh!

cyanglaz commented Jul 12, 2019

Uh oh!

cyanglaz commented Aug 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nosmirck commented Oct 26, 2018 •

edited

Loading