-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Fix cloud functions podspec. #691
Conversation
kroikie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @westoque Thanks for this PR, would you be able to bump the version number and add a note in the CHANGELOG?
|
@kroikie sure thing. will bump version and add a note in the CHANGELOG. |
This will fix compilation errors when doing a `pod install` because this package has static framework dependencies.
7a1f4e5 to
4e4227f
Compare
|
@kroikie done. |
|
@westoque Thanks for noticing these, I've been experiencing this dependency issue for a while and hopefully this solves it FYI did you perhaps bump the wrong package by mistake? It looks like the updated changelog in firebase_auth not cloud_functions. Would love it if you could bump and release cloud_functions when you get a moment Cheers |
This reverts commit 4e4227f.
kroikie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fix cloud functions podspec. This will fix compilation errors when doing a `pod install` because this package has static framework dependencies.
* Fix cloud functions podspec. This will fix compilation errors when doing a `pod install` because this package has static framework dependencies.
This reverts commit 61d5c9b.
* Fix cloud functions podspec. This will fix compilation errors when doing a `pod install` because this package has static framework dependencies.
This will fix compilation errors when doing a
pod installbecause this package has static framework dependencies.The error namely: