This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[image_picker] add requestFullMetadata for iOS (optional permissions) #5915
Merged
auto-submit
merged 63 commits into
flutter:main
from
PiotrMitkowski:ios-optional-permissions
Oct 5, 2022
Merged
Changes from 60 commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
5d3a9aa
Added new image picking method with flag for controlling metadata
PiotrMitkowski 4195dca
Updated tests with cases for the new method
PiotrMitkowski 7d255de
Updated changelog in platform interface and app-facing package to mat…
PiotrMitkowski 3fd7383
Updated app-facing package to call new method from platform interface
PiotrMitkowski 686bc22
Merge branch 'master' of github.com:flutter/plugins into ios-optional…
PiotrMitkowski 1f73191
Fixed version in changelog file
PiotrMitkowski 24d0679
Merge branch 'main' into ios-optional-permissions
PiotrMitkowski 1ba0c73
Merge branch 'main' into ios-optional-permissions
PiotrMitkowski 1084763
PR remarks
PiotrMitkowski a89ad0a
Renamed flag to better specify its purpose
PiotrMitkowski 8ff7492
Renamed flag in remaining occurences
PiotrMitkowski 193bbe9
Merge branch 'main' into ios-optional-permissions
PiotrMitkowski 95eef20
Fixed formatting and originalAsset assignment
PiotrMitkowski e10b24e
Merge remote-tracking branch 'origin/ios-optional-permissions' into i…
PiotrMitkowski f2c2e68
Resolved merge conflicts
PiotrMitkowski f5f94b2
PR remarks
PiotrMitkowski 97efdca
Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…
PiotrMitkowski bd3dfeb
Fixed issues after merge
PiotrMitkowski b99ba07
Added a test for picking image without full metadata
PiotrMitkowski 3d6c45c
Fixed code formatting
PiotrMitkowski b3e9166
Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…
PiotrMitkowski bf3f55c
PR remarks
PiotrMitkowski 742b259
Fixed linter warnings
PiotrMitkowski d41b390
Added dependency overrides for missing modules
PiotrMitkowski ead2f62
Fixed formatting
PiotrMitkowski 7b6ace9
Added options class for handling image picking settings
PiotrMitkowski 0f43653
Added missing license comment
PiotrMitkowski c6dcc49
Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…
PiotrMitkowski 9ba71b9
Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…
PiotrMitkowski c1fc9da
PR remarks
PiotrMitkowski 7f958a6
pbxproj version revert
PiotrMitkowski c825d09
PR remarks
PiotrMitkowski a2ca361
Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…
PiotrMitkowski 0120c47
Resolved merge conflicts
PiotrMitkowski 0827c80
Generated Pigeon files for new API and metadata flag
PiotrMitkowski 994e45f
Switched to use options object in private picking method
PiotrMitkowski 9b39e31
Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…
PiotrMitkowski 933254e
Fixed failing unit tests
PiotrMitkowski 66f14b2
Added missing tests for a new method and request full metadata parameter
PiotrMitkowski 47098ec
Fixed failing native tests
PiotrMitkowski 0a811d8
PR remarks
PiotrMitkowski 0789a7b
Fixed linting
PiotrMitkowski c5966d4
Removed dependency overrides
PiotrMitkowski 6f32405
Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…
PiotrMitkowski 217237b
PR remarks
PiotrMitkowski 7a4d250
Fixed linter warnings and failing tests
PiotrMitkowski 4ee04cb
Removed remaining dependency override
PiotrMitkowski b3fb220
Enforcing proper platform interface version having required API changes
PiotrMitkowski 4d884de
Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…
PiotrMitkowski c2240fa
Fixed failing test in app-facing plugin
PiotrMitkowski 2fea4be
Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…
PiotrMitkowski 839b574
Added missing tests
PiotrMitkowski b0b1d1b
Fixed formatting and linter issues
PiotrMitkowski 0c3fe02
Restored original interface version in Android example
PiotrMitkowski f9c8ea3
Fixed formatting in mocks
PiotrMitkowski 24a504b
Fixed docs lines length
PiotrMitkowski f842d76
PR remarks
PiotrMitkowski b45b4e6
PR remarks
PiotrMitkowski e357c56
Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…
PiotrMitkowski 5567f8c
PR remarks
PiotrMitkowski 58d6b10
Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…
PiotrMitkowski f80f09d
Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…
PiotrMitkowski 39e8d37
Updated package with iOS implementation to fix a bug
PiotrMitkowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be
0.8.6+1now to pick up the last fix.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still waiting for this version to be published on pub.dev. It seems that the release action failed. Could you take a look? https://github.com/flutter/plugins/actions/runs/3084943502
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, sorry about that; I forgot to check that publishing had completed. It looks like there was a flake in the analysis run during post-submit tests, and it's already being re-run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's live. Sorry for the delay!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to go now, thanks!