[webview_flutter] Expose the allowsLinkPreview property in WKWebView for iOS

packages/webview_flutter/webview_flutter/CHANGELOG.md

@@ -2,6 +2,7 @@
 
 * Ignores unnecessary import warnings in preparation for [upcoming Flutter changes](https://github.com/flutter/flutter/pull/104231).
 * Updates references to the obsolete master branch.
+* Adds support for the `allowsLinkPreview` property on iOS.
 
 ## 3.0.4
 

packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart

@@ -1149,6 +1149,32 @@ Future<void> main() async {
     expect(currentUrl, primaryUrl);
   });
 
+  testWidgets('launches with allowsLinkPreview on iOS',
+      (WidgetTester tester) async {
+    final Completer<WebViewController> controllerCompleter =
+        Completer<WebViewController>();
+    await tester.pumpWidget(
+      Directionality(
+        textDirection: TextDirection.ltr,
+        child: SizedBox(
+          width: 400,
+          height: 300,
+          child: WebView(
+            key: GlobalKey(),
+            initialUrl: primaryUrl,
+            allowsLinkPreview: false,
+            onWebViewCreated: (WebViewController controller) {
+              controllerCompleter.complete(controller);
+            },
+          ),
+        ),
+      ),
+    );
+    final WebViewController controller = await controllerCompleter.future;
+    final String? currentUrl = await controller.currentUrl();
+    expect(currentUrl, primaryUrl);
+  });
+
   // TODO(bparrishMines): skipped due to https://github.com/flutter/flutter/issues/86757
   testWidgets('target _blank opens in same window',
       (WidgetTester tester) async {

packages/webview_flutter/webview_flutter/lib/src/webview.dart

@@ -90,6 +90,7 @@ class WebView extends StatefulWidget {
     this.onWebResourceError,
     this.debuggingEnabled = false,
     this.gestureNavigationEnabled = false,
+    this.allowsLinkPreview = true,
     this.userAgent,
     this.zoomEnabled = true,
     this.initialMediaPlaybackPolicy =
@@ -260,6 +261,13 @@ class WebView extends StatefulWidget {
   /// By default `gestureNavigationEnabled` is false.
   final bool gestureNavigationEnabled;
 
+  /// A Boolean value that determines whether pressing a link displays a preview of the destination for the link.
+  ///
+  /// This only works on iOS.
+  ///
+  /// By default `allowsLinkPreview` is true, to match the default on iOS.
+  final bool allowsLinkPreview;
+
   /// The value used for the HTTP User-Agent: request header.
   ///
   /// When null the platform's webview default is used for the User-Agent header.
@@ -380,6 +388,7 @@ WebSettings _webSettingsFromWidget(WebView widget) {
     hasProgressTracking: widget.onProgress != null,
     debuggingEnabled: widget.debuggingEnabled,
     gestureNavigationEnabled: widget.gestureNavigationEnabled,
+    allowsLinkPreview: widget.allowsLinkPreview,
     allowsInlineMediaPlayback: widget.allowsInlineMediaPlayback,
     userAgent: WebSetting<String?>.of(widget.userAgent),
     zoomEnabled: widget.zoomEnabled,

packages/webview_flutter/webview_flutter/pubspec.yaml

@@ -19,9 +19,18 @@ flutter:
 dependencies:
   flutter:
     sdk: flutter
-  webview_flutter_android: ^2.8.0
-  webview_flutter_platform_interface: ^1.8.0
-  webview_flutter_wkwebview: ^2.7.0
+  # FOR TESTING ONLY. DO NOT MERGE.
+  webview_flutter_android:
+    path:
+      ../webview_flutter_android
+  # FOR TESTING ONLY. DO NOT MERGE.
+  webview_flutter_platform_interface:
+    path:
+      ../webview_flutter_platform_interface
+  # FOR TESTING ONLY. DO NOT MERGE.
+  webview_flutter_wkwebview:
+    path:
+      ../webview_flutter_wkwebview
 
 dev_dependencies:
   build_runner: ^2.1.5

packages/webview_flutter/webview_flutter/test/webview_flutter_test.dart

@@ -1139,6 +1139,7 @@ void main() {
         const WebView(
           initialUrl: 'https://youtube.com',
           gestureNavigationEnabled: true,
+          allowsLinkPreview: false,
         ),
       );
 
@@ -1155,6 +1156,7 @@ void main() {
               debuggingEnabled: false,
               userAgent: const WebSetting<String?>.of(null),
               gestureNavigationEnabled: true,
+              allowsLinkPreview: false,
               zoomEnabled: true,
             ),
           )));
@@ -1337,6 +1339,7 @@ class MatchesWebSettings extends Matcher {
         _webSettings!.debuggingEnabled == webSettings.debuggingEnabled &&
         _webSettings!.gestureNavigationEnabled ==
             webSettings.gestureNavigationEnabled &&
+        _webSettings!.allowsLinkPreview == webSettings.allowsLinkPreview &&
         _webSettings!.userAgent == webSettings.userAgent &&
         _webSettings!.zoomEnabled == webSettings.zoomEnabled;
   }

packages/webview_flutter/webview_flutter_android/example/integration_test/webview_flutter_test.dart

@@ -1241,6 +1241,32 @@ Future<void> main() async {
     expect(currentUrl, primaryUrl);
   });
 
+  testWidgets('launches with allowsLinkPreview on iOS',
+      (WidgetTester tester) async {
+    final Completer<WebViewController> controllerCompleter =
+        Completer<WebViewController>();
+    await tester.pumpWidget(
+      Directionality(
+        textDirection: TextDirection.ltr,
+        child: SizedBox(
+          width: 400,
+          height: 300,
+          child: WebView(
+            key: GlobalKey(),
+            initialUrl: primaryUrl,
+            allowsLinkPreview: false,
+            onWebViewCreated: (WebViewController controller) {
+              controllerCompleter.complete(controller);
+            },
+          ),
+        ),
+      ),
+    );
+    final WebViewController controller = await controllerCompleter.future;
+    final String? currentUrl = await controller.currentUrl();
+    expect(currentUrl, primaryUrl);
+  });
+
   testWidgets('target _blank opens in same window',
       (WidgetTester tester) async {
     final Completer<WebViewController> controllerCompleter =

packages/webview_flutter/webview_flutter_android/example/lib/web_view.dart

@@ -74,6 +74,7 @@ class WebView extends StatefulWidget {
     this.onWebResourceError,
     this.debuggingEnabled = false,
     this.gestureNavigationEnabled = false,
+    this.allowsLinkPreview = true,
     this.userAgent,
     this.zoomEnabled = true,
     this.initialMediaPlaybackPolicy =
@@ -216,6 +217,13 @@ class WebView extends StatefulWidget {
   /// By default `gestureNavigationEnabled` is false.
   final bool gestureNavigationEnabled;
 
+  /// A Boolean value that determines whether pressing a link displays a preview of the destination for the link.
+  ///
+  /// This only works on iOS.
+  ///
+  /// By default `allowsLinkPreview` is true, to match the default on iOS.
+  final bool allowsLinkPreview;
+
   /// A Boolean value indicating whether the WebView should support zooming using its on-screen zoom controls and gestures.
   ///
   /// By default 'zoomEnabled' is true
@@ -676,6 +684,7 @@ WebSettings _webSettingsFromWidget(WebView widget) {
     hasProgressTracking: widget.onProgress != null,
     debuggingEnabled: widget.debuggingEnabled,
     gestureNavigationEnabled: widget.gestureNavigationEnabled,
+    allowsLinkPreview: widget.allowsLinkPreview,
     allowsInlineMediaPlayback: widget.allowsInlineMediaPlayback,
     userAgent: WebSetting<String?>.of(widget.userAgent),
     zoomEnabled: widget.zoomEnabled,

packages/webview_flutter/webview_flutter_android/pubspec.yaml

@@ -19,7 +19,10 @@ flutter:
 dependencies:
   flutter:
     sdk: flutter
-  webview_flutter_platform_interface: ^1.8.0
+  # FOR TESTING ONLY. DO NOT MERGE.
+  webview_flutter_platform_interface:
+    path:
+      ../webview_flutter_platform_interface
 
 dev_dependencies:
   build_runner: ^2.1.4

packages/webview_flutter/webview_flutter_platform_interface/CHANGELOG.md

@@ -1,6 +1,7 @@
 ## NEXT
 
 * Ignores unnecessary import warnings in preparation for [upcoming Flutter changes](https://github.com/flutter/flutter/pull/106316).
+* Adds support for the `allowsLinkPreview` property on iOS.
 
 ## 1.9.1
 

packages/webview_flutter/webview_flutter_platform_interface/lib/src/method_channel/webview_method_channel.dart

@@ -267,6 +267,7 @@ class MethodChannelWebViewPlatform implements WebViewPlatformController {
     _addIfNonNull('debuggingEnabled', settings.debuggingEnabled);
     _addIfNonNull(
         'gestureNavigationEnabled', settings.gestureNavigationEnabled);
+    _addIfNonNull('allowsLinkPreview', settings.allowsLinkPreview);
     _addIfNonNull(
         'allowsInlineMediaPlayback', settings.allowsInlineMediaPlayback);
     _addSettingIfPresent('userAgent', settings.userAgent);

packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/web_settings.dart

@@ -82,6 +82,7 @@ class WebSettings {
     this.hasProgressTracking,
     this.debuggingEnabled,
     this.gestureNavigationEnabled,
+    this.allowsLinkPreview,
     this.allowsInlineMediaPlayback,
     this.zoomEnabled,
     required this.userAgent,
@@ -125,8 +126,13 @@ class WebSettings {
   /// See also: [WebView.gestureNavigationEnabled]
   final bool? gestureNavigationEnabled;
 
+  /// Determines whether pressing a link displays a preview of the destination for the link in iOS.
+  ///
+  /// See also: [WebView.allowsLinkPreview]
+  final bool? allowsLinkPreview;
+
   @override
   String toString() {
-    return 'WebSettings(javascriptMode: $javascriptMode, hasNavigationDelegate: $hasNavigationDelegate, hasProgressTracking: $hasProgressTracking, debuggingEnabled: $debuggingEnabled, gestureNavigationEnabled: $gestureNavigationEnabled, userAgent: $userAgent, allowsInlineMediaPlayback: $allowsInlineMediaPlayback)';
+    return 'WebSettings(javascriptMode: $javascriptMode, hasNavigationDelegate: $hasNavigationDelegate, hasProgressTracking: $hasProgressTracking, debuggingEnabled: $debuggingEnabled, gestureNavigationEnabled: $gestureNavigationEnabled, allowsLinkPreview: $allowsLinkPreview, userAgent: $userAgent, allowsInlineMediaPlayback: $allowsInlineMediaPlayback)';
   }
 }

packages/webview_flutter/webview_flutter_platform_interface/test/src/method_channel/webview_method_channel_test.dart

@@ -440,6 +440,7 @@ void main() {
         hasProgressTracking: true,
         debuggingEnabled: true,
         gestureNavigationEnabled: true,
+        allowsLinkPreview: false,
         allowsInlineMediaPlayback: true,
         zoomEnabled: false,
       );
@@ -457,6 +458,7 @@ void main() {
               'hasProgressTracking': true,
               'debuggingEnabled': true,
               'gestureNavigationEnabled': true,
+              'allowsLinkPreview': false,
               'allowsInlineMediaPlayback': true,
               'zoomEnabled': false,
             },

packages/webview_flutter/webview_flutter_web/example/lib/web_view.dart

@@ -377,6 +377,7 @@ WebSettings _webSettingsFromWidget(WebView widget) {
     hasProgressTracking: false,
     debuggingEnabled: false,
     gestureNavigationEnabled: false,
+    allowsLinkPreview: true,
     allowsInlineMediaPlayback: true,
     userAgent: const WebSetting<String?>.of(''),
     zoomEnabled: false,

packages/webview_flutter/webview_flutter_web/pubspec.yaml

@@ -21,7 +21,10 @@ dependencies:
     sdk: flutter
   flutter_web_plugins:
     sdk: flutter
-  webview_flutter_platform_interface: ^1.8.0
+  # FOR TESTING ONLY. DO NOT MERGE.
+  webview_flutter_platform_interface:
+    path:
+      ../webview_flutter_platform_interface
 
 dev_dependencies:
   build_runner: ^2.1.5

packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md

@@ -2,6 +2,7 @@
 
 * Fixes crash when an Objective-C object in `FWFInstanceManager` is released, but the dealloc
   callback is no longer available.
+* Adds support for the `allowsLinkPreview` property on iOS.
 
 ## 2.9.1
 

packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/webview_flutter_test.dart

@@ -1095,6 +1095,32 @@ Future<void> main() async {
     });
   });
 
+  testWidgets('launches with allowsLinkPreview on iOS',
+      (WidgetTester tester) async {
+    final Completer<WebViewController> controllerCompleter =
+        Completer<WebViewController>();
+    await tester.pumpWidget(
+      Directionality(
+        textDirection: TextDirection.ltr,
+        child: SizedBox(
+          width: 400,
+          height: 300,
+          child: WebView(
+            key: GlobalKey(),
+            initialUrl: primaryUrl,
+            allowsLinkPreview: false,
+            onWebViewCreated: (WebViewController controller) {
+              controllerCompleter.complete(controller);
+            },
+          ),
+        ),
+      ),
+    );
+    final WebViewController controller = await controllerCompleter.future;
+    final String? currentUrl = await controller.currentUrl();
+    expect(currentUrl, primaryUrl);
+  });
+
   testWidgets('launches with gestureNavigationEnabled on iOS',
       (WidgetTester tester) async {
     final Completer<WebViewController> controllerCompleter =

packages/webview_flutter/webview_flutter_wkwebview/example/lib/web_view.dart

@@ -66,6 +66,7 @@ class WebView extends StatefulWidget {
     this.onWebResourceError,
     this.debuggingEnabled = false,
     this.gestureNavigationEnabled = false,
+    this.allowsLinkPreview = true,
     this.userAgent,
     this.zoomEnabled = true,
     this.initialMediaPlaybackPolicy =
@@ -206,6 +207,13 @@ class WebView extends StatefulWidget {
   /// By default `gestureNavigationEnabled` is false.
   final bool gestureNavigationEnabled;
 
+  /// A Boolean value that determines whether pressing a link displays a preview of the destination for the link.
+  ///
+  /// This only works on iOS.
+  ///
+  /// By default `allowsLinkPreview` is true, to match the default on iOS.
+  final bool allowsLinkPreview;
+
   /// The value used for the HTTP User-Agent: request header.
   ///
   /// When null the platform's webview default is used for the User-Agent header.
@@ -622,6 +630,7 @@ WebSettings _webSettingsFromWidget(WebView widget) {
     hasProgressTracking: widget.onProgress != null,
     debuggingEnabled: widget.debuggingEnabled,
     gestureNavigationEnabled: widget.gestureNavigationEnabled,
+    allowsLinkPreview: widget.allowsLinkPreview,
     allowsInlineMediaPlayback: widget.allowsInlineMediaPlayback,
     userAgent: WebSetting<String?>.of(widget.userAgent),
     zoomEnabled: widget.zoomEnabled,

packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml

@@ -19,7 +19,10 @@ dependencies:
   flutter:
     sdk: flutter
   path: ^1.8.0
-  webview_flutter_platform_interface: ^1.8.0
+  # FOR TESTING ONLY. DO NOT MERGE.
+  webview_flutter_platform_interface:
+    path:
+      ../webview_flutter_platform_interface
 
 dev_dependencies:
   build_runner: ^2.1.5