Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] Error handling when URL cannot be parsed with Uri.parse #4365

Merged
fluttergithubbot merged 8 commits into from
Sep 23, 2021
Merged

[url_launcher] Error handling when URL cannot be parsed with Uri.parse #4365

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8f8ed7d
[url_launcher] Error handling when URL cannot be parsed with Uri.parse
Baw-Appie Sep 21, 2021
7f89725
[url_launcher] Add tests for Microsoft Remote Desktop URL
Baw-Appie Sep 22, 2021
6a7b272
[url_launcher] Fix try block to catch only FormatException
Baw-Appie Sep 22, 2021
2f7d786
[url_launcher] Formatting test codes
Baw-Appie Sep 22, 2021
4da3eb7
[url_launcher] Update version to 6.0.12
Baw-Appie Sep 22, 2021
de9b86b
[url_launcher] Fix empty_catches warning
Baw-Appie Sep 22, 2021
0bde82d
[url_launcher] Use Uri.tryParse instead of try-catch
Baw-Appie Sep 22, 2021
3751fe9
[url_launcher] Update tests name
Baw-Appie Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions packages/url_launcher/url_launcher/lib/url_launcher.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,18 @@ Future<bool> launch(
Brightness? statusBarBrightness,
String? webOnlyWindowName,
}) async {
final Uri url = Uri.parse(urlString.trimLeft());
final bool isWebURL = url.scheme == 'http' || url.scheme == 'https';
if ((forceSafariVC == true || forceWebView == true) && !isWebURL) {
throw PlatformException(
code: 'NOT_A_WEB_SCHEME',
message: 'To use webview or safariVC, you need to pass'
'in a web URL. This $urlString is not a web URL.');
}
bool isWebURL = false;
try {
final Uri url = Uri.parse(urlString.trimLeft());

isWebURL = url.scheme == 'http' || url.scheme == 'https';
if ((forceSafariVC == true || forceWebView == true) && !isWebURL) {
throw PlatformException(
code: 'NOT_A_WEB_SCHEME',
message: 'To use webview or safariVC, you need to pass'
'in a web URL. This $urlString is not a web URL.');
}
} catch (e) {}
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only be wrapping parse, not everything (especially not the throw) and should only catch the specific exception it is intended to handle.


/// [true] so that ui is automatically computed if [statusBarBrightness] is set.
bool previousAutomaticSystemUiAdjustment = true;
Expand Down