Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Fix playback speed resetting on iOS #4331

Closed
alexagat wants to merge 3 commits into from
Closed

[video_player] Fix playback speed resetting on iOS #4331

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eef3a69
Fix bug where playback speed would reset to 1 upon seek; Store local …
alexagat Sep 6, 2021
3d62e8e
Fix lint error
alexagat Sep 10, 2021
9563754
Remove unnecessary code
alexagat Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/video_player/video_player/ios/Classes/FLTVideoPlayerPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ @interface FLTVideoPlayer : NSObject <FlutterTexture, FlutterStreamHandler>
@property(nonatomic, readonly) bool disposed;
@property(nonatomic, readonly) bool isPlaying;
@property(nonatomic) bool isLooping;
@property(nonatomic) double internalPlaybackSpeed;
@property(nonatomic, readonly) bool isInitialized;
- (instancetype)initWithURL:(NSURL*)url
frameUpdater:(FLTFrameUpdater*)frameUpdater
Expand Down Expand Up @@ -310,6 +311,9 @@ - (void)updatePlayingState {
}
if (_isPlaying) {
[_player play];

// fix to always set playback speed accurately
[self setPlaybackSpeed:_internalPlaybackSpeed];
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Sep 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this always needed here? My impression from comments in the issue was that calling it from the completion handler of the seek method would likely be enough.

Copy link
Author

@alexagat alexagat Sep 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartmorgan which completion handler are you referring to? I only see a seekTo method in the file.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Sep 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See flutter/flutter#71264 (comment)

Copy link
Author

@alexagat alexagat Sep 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartmorgan I see. I tried moving the call inside the completionHandler block of the seekTo method as follows:

[_player seekToTime:CMTimeMake(location, 1000)
      toleranceBefore:kCMTimeZero
       toleranceAfter:kCMTimeZero
    completionHandler:^(BOOL finished) {
    [self setPlaybackSpeed:_internalPlaybackSpeed];
  }];

but the issue of the playback speed resetting to 1.0 came back. Therefore that is not equivalent.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Sep 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. So presumably then it's the playbackLikelyToKeepUpContext and/or AVPlayerItemStatusReadyToPlay codepath that's resolving this? In which case perhaps the underlying issue is that AVPlayer automatically resets the playback speed when the buffer is insufficient.

} else {
[_player pause];
}
Expand Down Expand Up @@ -394,6 +398,7 @@ - (void)setPlaybackSpeed:(double)speed {
return;
}

[self setInternalPlaybackSpeed:speed];
_player.rate = speed;
}

Expand Down