Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@flyaswind
Copy link

i found no settings for the mixedContentMode,when a https website contains http , the webview appears empty
i tried to provide settings for the mixedContentMode , and set the mixedContentMode on WebSettings on the Android platform

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla
Copy link

google-cla bot commented May 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 8, 2021
@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-android labels May 8, 2021
@stuartmorgan-g
Copy link
Contributor

Thanks for the contribution! It looks like this is essentially the same as #3867; see discussion there. I would suggest closing this and following up there, unless you believe there's some specific way this improves over that version that couldn't be incorporated.

@ditman
Copy link
Member

ditman commented Jun 3, 2021

Unfortunately we’re unable to accept PRs without a signed CLA. If you sign the CLA in the future, please comment to let us know, and we can re-open this PR.

Alternatively, you can take a look at these related PRs, maybe they can use your help to get landed:

@ditman ditman closed this Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: no p: webview_flutter Edits files for a webview_flutter plugin platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants