Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Update PULL_REQUEST_TEMPLATE.md #3801

Merged
fluttergithubbot merged 12 commits into from
Apr 20, 2021
Merged

Update PULL_REQUEST_TEMPLATE.md #3801

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1dd2374
Update PULL_REQUEST_TEMPLATE.md
Apr 8, 2021
802d1fe
Update PULL_REQUEST_TEMPLATE.md
Apr 8, 2021
2c009a5
Update PULL_REQUEST_TEMPLATE.md
Apr 8, 2021
1569e8a
review
Apr 14, 2021
5ed2124
fix typo
Apr 14, 2021
c815fa2
review
Apr 15, 2021
2c645ea
fix
Apr 15, 2021
a771e18
Merge branch 'master' into cyanglaz-patch-1
Apr 15, 2021
a39a7a7
Merge branch 'master' into cyanglaz-patch-1
Apr 15, 2021
f7fe935
review
Apr 19, 2021
8408aa3
review 2
Apr 19, 2021
74ef085
Merge branch 'master' into cyanglaz-patch-1
Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

- [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
- [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. (Note that not like the flutter/flutter repo, we do use dart formatter in the flutter/plugins repo.)
Copy link
Member

@ditman ditman Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

[ ] I have formatted this PR with `dartfmt -w .`, read the [Flutter Style Guide] and followed the [C++, Objective-C, Java style guides].

Is there a plugins command that we can provide so users can quickly format all the source they might have touched in their PR? Something that guarantees that the format step will pass?

Copy link

@blasten blasten Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make sense to say dart run ./script/tool/lib/src/main.dart format this those all of those.

Copy link
Contributor Author

@cyanglaz cyanglaz Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

- [ ] I signed the [CLA].
- [ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. `[shared_preferences]`
- [ ] I listed at least one issue that this PR fixes in the description above.
Expand Down