Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] re-enable test for playing video with assets #3219

Closed
cyanglaz wants to merge 13 commits into from
Closed

[video_player] re-enable test for playing video with assets #3219

Changes from 8 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b379a92
re-enable tests
Oct 28, 2020
4cf12ed
run drive on android tests
Oct 28, 2020
db790f2
move drive after firebase test lab
Oct 28, 2020
7c4c0af
fiox
Oct 28, 2020
7235535
revert changes to main
Oct 28, 2020
06da96d
remove todo
Oct 28, 2020
3ac837f
fix
Oct 30, 2020
72aa428
revert cirrus change
Oct 30, 2020
4e32994
add sdk constraint to the example app
Oct 30, 2020
39e5df1
test ci
Oct 31, 2020
ab3bd68
re-enable integration tests
Oct 31, 2020
80c7758
remove driver test files
Oct 31, 2020
6658838
remove unused imports
Oct 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/video_player/video_player/example/test_driver/video_player_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ Future<void> main() async {
});

//TODO(cyanglaz): Use TabBar tabs to navigate between pages after https://github.com/flutter/flutter/issues/16991 is fixed.
//TODO(cyanglaz): Un-skip the test after https://github.com/flutter/flutter/issues/43012 is fixed
test('Push a page contains video and pop back, do not crash.', () async {
final SerializableFinder pushTab = find.byValueKey('push_tab');
await driver.waitFor(pushTab);
Expand All @@ -23,5 +22,5 @@ Future<void> main() async {
await driver.waitUntilNoTransientCallbacks();
final Health health = await driver.checkHealth();
expect(health.status, HealthStatus.ok);
}, skip: 'Cirrus CI currently hangs while playing videos');
});
}