Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[connectivity] announce 1.0, deprecate wifi APIs #3183

Merged
cyanglaz merged 8 commits into from
Oct 22, 2020
Merged

[connectivity] announce 1.0, deprecate wifi APIs #3183

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e5f8687
1.0
Oct 21, 2020
63187af
typo
Oct 21, 2020
c7b515e
typo
Oct 21, 2020
084ee6c
Update FLTConnectivityPlugin.m
Oct 21, 2020
82d7b1d
add ignores
Oct 21, 2020
a0c2da4
format
Oct 22, 2020
797d8e0
format
Oct 22, 2020
b9702d7
updated to deprecated_member_use_from_same_package
Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ges/connectivity/connectivity/example/test_driver/integration_test/connectivity_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ void main() {
expect(result, isNotNull);
switch (result) {
case ConnectivityResult.wifi:

Copy link
Contributor

@amirh amirh Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line?

Copy link
Contributor Author

@cyanglaz cyanglaz Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

expect(_connectivity.getWifiName(), completes);
expect(_connectivity.getWifiBSSID(), completes);
expect((await _connectivity.getWifiIP()), isNotNull);
Expand Down
4 changes: 4 additions & 0 deletions packages/connectivity/connectivity/integration_test/connectivity_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,11 @@ void main() {
expect(result, isNotNull);
switch (result) {
case ConnectivityResult.wifi:
// ignore: deprecated_member_use
expect(_connectivity.getWifiName(), completes);
// ignore: deprecated_member_use
expect(_connectivity.getWifiBSSID(), completes);
// ignore: deprecated_member_use
expect((await _connectivity.getWifiIP()), isNotNull);
break;
default:
Expand All @@ -33,6 +36,7 @@ void main() {

testWidgets('test location methods, iOS only', (WidgetTester tester) async {
if (Platform.isIOS) {
// ignore: deprecated_member_use
expect((await _connectivity.getLocationServiceAuthorization()),
LocationAuthorizationStatus.notDetermined);
}
Expand Down
5 changes: 5 additions & 0 deletions packages/connectivity/connectivity/test/connectivity_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,28 +35,33 @@ void main() {
});

test('getWifiName', () async {
// ignore: deprecated_member_use
String result = await connectivity.getWifiName();
expect(result, kWifiNameResult);
});

test('getWifiBSSID', () async {
// ignore: deprecated_member_use
String result = await connectivity.getWifiBSSID();
expect(result, kWifiBSSIDResult);
});

test('getWifiIP', () async {
// ignore: deprecated_member_use
String result = await connectivity.getWifiIP();
expect(result, kWifiIpAddressResult);
});

test('requestLocationServiceAuthorization', () async {
LocationAuthorizationStatus result =
// ignore: deprecated_member_use
await connectivity.requestLocationServiceAuthorization();
expect(result, kRequestLocationResult);
});

test('getLocationServiceAuthorization', () async {
LocationAuthorizationStatus result =
// ignore: deprecated_member_use
await connectivity.getLocationServiceAuthorization();
expect(result, kRequestLocationResult);
});
Expand Down