This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] Fixes an issue where videos could be wrongly picked with .jpg extension #3172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened from #2860.
Fixes an issue where videos could be wrongly picked with
.jpgextension.Description
When picking videos on Android devices, it will return file names ended with
.jpgextension, regardless of the file being actually a video. This requires a workaround implementation, such as opening a File descriptor on Flutter side and rename it to.mp4again.The issue happens because some URI paths doesn't have an extension and it was being extracted just by splitting the file name from
.and getting the last part, which make it not quite reliable for some scenarios. Right now, I've updated the source to retrieve the extension based on the URI content.As a note, this doesn't happen with all Android devices, but I can see it easily replicable with Samsung phones.
Related Issues
Fixes #52419
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?