Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@miguelpruivo
Copy link

@miguelpruivo miguelpruivo commented Oct 20, 2020

Opened from #2860.

Fixes an issue where videos could be wrongly picked with .jpg extension.

Description

When picking videos on Android devices, it will return file names ended with .jpg extension, regardless of the file being actually a video. This requires a workaround implementation, such as opening a File descriptor on Flutter side and rename it to .mp4 again.

The issue happens because some URI paths doesn't have an extension and it was being extracted just by splitting the file name from . and getting the last part, which make it not quite reliable for some scenarios. Right now, I've updated the source to retrieve the extension based on the URI content.

As a note, this doesn't happen with all Android devices, but I can see it easily replicable with Samsung phones.

Related Issues

Fixes #52419

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@jb522185660
Copy link

how do you resolved it , I have get the image_picker: ^0.6.7+14,but it also return jpg

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[image_picker] image_picker returns .jpg extension when picking Video or GIF

2 participants