Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] suppress a uses or overrides a deprecated API warning in WebViewActivity #3132

Merged
amirh merged 6 commits into from
Oct 21, 2020
Merged

[url_launcher] suppress a uses or overrides a deprecated API warning in WebViewActivity #3132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0727036
Deprecation warning suppressed
Oct 8, 2020
7e86e76
Changed CHANGELOG.md and pubspec.yaml accordingly
Oct 8, 2020
35e7797
Added explanation
Oct 8, 2020
645cf93
Fix formatting
Oct 9, 2020
4a0b3d5
fixed pubspec and merge conflicts
Oct 16, 2020
d24db04
Merge branch 'master' into issue-60986
Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/url_launcher/url_launcher/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 5.7.6

* Suppress deprecation warning on the `shouldOverrideUrlLoading` method on Android of the `FlutterWebChromeClient` class.

## 5.7.5

* Improved documentation of the `headers` parameter.
Expand Down
5 changes: 5 additions & 0 deletions ...er/url_launcher/android/src/main/java/io/flutter/plugins/urllauncher/WebViewActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ public boolean shouldOverrideUrlLoading(
return true;
}

/*
* This method is deprecated in API 24. Still overridden to support
* earlier Android versions.
*/
@SuppressWarnings("deprecation")
@Override
public boolean shouldOverrideUrlLoading(WebView view, String url) {
webview.loadUrl(url);
Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: url_launcher
description: Flutter plugin for launching a URL on Android and iOS. Supports
web, phone, SMS, and email schemes.
homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher
version: 5.7.5
version: 5.7.6

flutter:
plugin:
Expand Down