Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@feinstein
Copy link
Contributor

@feinstein feinstein commented Aug 27, 2020

Description

This is related to flutter/flutter#26705 and many others. I already fixed this before on flutter/flutter#37343 submitting this PR #1937.

I am fixing this again.

Could the owners of these files make some sort of mechanism to avoid this from happening again?


I need some help with the tests, I honestly don't understand why the 'can sign in after init failed before' test is failing. For some reason the MockMethodCallHandler is only being called once. I didn't change anything on this test (just syntactic sugar, but it also fails if I remove it).

Related Issues

Fixes flutter/flutter#64681
Fixes flutter/flutter#45146

flutter/flutter#37343
flutter/flutter#26705
dart-lang/sdk#37268

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@feinstein
Copy link
Contributor Author

@mehmetf could you help me figure out what's the problem with the tests?

@stuartmorgan-g
Copy link
Contributor

All of the referenced issues are closed, referring to an issue that was recently fixed in the Dart VM. Given that, is this PR still necessary?

@stuartmorgan-g
Copy link
Contributor

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks!

@feinstein
Copy link
Contributor Author

Sorry Stuart, I forgot to reply... Yeah I don't think it's necessary anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

3 participants