Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[e2e] Add new e2e_driver for handling response data and performance watcher #2906

Merged
CareF merged 6 commits into from
Aug 5, 2020
Merged

[e2e] Add new e2e_driver for handling response data and performance watcher #2906

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b60d2f
add new driver and perf
CareF Aug 3, 2020
d8fffef
formatting
CareF Aug 4, 2020
72f6169
versioning
CareF Aug 4, 2020
9953308
modify according to AlbertWang0116@
CareF Aug 5, 2020
21f550a
modify according to liyuqian@
CareF Aug 5, 2020
7dfaf1e
metricName -> reportKey
CareF Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/e2e/lib/e2e_driver.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@ typedef ResponseDataCallback = FutureOr<void> Function(Map<String, dynamic>);
/// This is the default `responseDataCallback` in [e2eDriver].
Future<void> writeResponseData(
Map<String, dynamic> data, {
String testOutputFilename = 'e2e_perf_summary',
String testOutputFilename = 'e2e_response_data',
String destinationDirectory,
}) async {
assert(testOutputFilename != null);
await fs.directory(testOutputsDirectory).create(recursive: true);
destinationDirectory ??= testOutputsDirectory;
await fs.directory(destinationDirectory).create(recursive: true);
final File file = fs.file(path.join(
testOutputsDirectory,
destinationDirectory,
'$testOutputFilename.json',
));
final String resultString = _encodeJson(data, true);
Expand Down Expand Up @@ -74,7 +76,9 @@ Future<void> e2eDriver({

if (response.allTestsPassed) {
print('All tests passed.');
await responseDataCallback(response.data);
if (responseDataCallback != null) {
await responseDataCallback(response.data);
}
exit(0);
} else {
print('Failure Details:\n${response.formattedFailureDetails}');
Expand Down
8 changes: 4 additions & 4 deletions packages/e2e/lib/e2e_perf.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ const String kDebugWarning = '''
/// watches the [FrameTiming] of `action` and report it to the e2e binding.
Future<void> watchPerformance(
E2EWidgetsFlutterBinding binding,
Future<void> action(),
) async {
Future<void> action(), {
String metricName = 'performance',
}) async {
assert(() {
if (_firstRun) {
debugPrint(kDebugWarning);
Expand All @@ -55,9 +56,8 @@ Future<void> watchPerformance(
binding.addTimingsCallback(watcher);
await action();
binding.removeTimingsCallback(watcher);
// TODO(CareF): determine if it's running on firebase and report metric online
final FrameTimingSummarizer frameTimes = FrameTimingSummarizer(frameTimings);
binding.reportData = <String, dynamic>{'performance': frameTimes.summary};
binding.reportData = <String, dynamic>{metricName: frameTimes.summary};
}

/// This class and summarizes a list of [FrameTiming] for the performance
Expand Down