Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/camera/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.5.7

* Fix unawaited futures.

## 0.5.6+4

* Android: Use CameraDevice.TEMPLATE_RECORD to improve image streaming.
Expand Down
1 change: 0 additions & 1 deletion packages/camera/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,3 @@ include: ../../analysis_options.yaml
analyzer:
errors:
public_member_api_docs: ignore
unawaited_futures: ignore
2 changes: 2 additions & 0 deletions packages/camera/example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// ignore_for_file: public_member_api_docs

import 'dart:async';
import 'dart:io';

Expand Down
2 changes: 1 addition & 1 deletion packages/camera/example/test_driver/camera_e2e.dart
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ void main() {
sleep(const Duration(milliseconds: 500));

await controller.stopImageStream();
controller.dispose();
await controller.dispose();
},
skip: !Platform.isAndroid,
);
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/example/test_driver/camera_e2e_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Future<void> main() async {
final FlutterDriver driver = await FlutterDriver.connect();
final String result =
await driver.requestData(null, timeout: const Duration(minutes: 1));
driver.close();
await driver.close();
print('Test finished. Revoking camera permissions...');
Process.runSync('adb', <String>[
'shell',
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/lib/camera.dart
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ class CameraController extends ValueNotifier<CameraValue> {
throw CameraException(e.code, e.message);
}

_imageStreamSubscription.cancel();
await _imageStreamSubscription.cancel();
_imageStreamSubscription = null;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/camera/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: camera
description: A Flutter plugin for getting information about and controlling the
camera on Android and iOS. Supports previewing the camera feed, capturing images, capturing video,
and streaming image buffers to dart.
version: 0.5.6+3
version: 0.5.7

authors:
- Flutter Team <[email protected]>
Expand Down