-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[url_launcher] Adds macOS support #2187
[url_launcher] Adds macOS support #2187
Conversation
Follows the structure established in flutter#2119 to add a federated macOS implementation of the url_launcher plugin. Fixes macOS portion of flutter/flutter#41721
|
/cc @franciscojma86 |
|
This doesn't include tests, since I'm not sure what the integration test strategy for federated plugins is. Should the example in the main plugin depend on the federated version and include macOS support? |
Interesting point, we should probably think about it some more, I think it would be nice if the platform package could provide the example's platform scaffold (e.g for Android that will be the Activity, manifest etc...) and the e2e tests that are specified in the app-facing plugin will be executed as part of the macOS CI. Though devil is in the details, and I'm not sure how we'll end up with a pubspec that has all the example app's dependencies but also a dependency on the unendorsed implementation. |
amirh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed the swift code but the structure and docs all make sense.
We probably need some test before this can land, so either we figure out the e2e testing story, or maybe it's possible to come up with a unit test for the swift code?
|
@franciscojma86 once we have driver testing of Mac apps on CI, this PR can land. |
|
Obsoleted by #2383 |
Description
Follows the structure established in #2119 to add a federated macOS implementation of the url_launcher plugin.
Related Issues
Fixes macOS portion of flutter/flutter#41721
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?