-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[path_provider] support the v2 embedder #2153
Conversation
|
Currently existing drive test fails because of exception (before my changes): this test expects |
|
Also |
|
You can include an EmbeddingV1ActivityTest.java for the old embedder and MainActivityTest.java for the new embedder and CI will run both of them. See #2160 for an example. |
8ff2b11 to
b746aed
Compare
|
@collinjackson when I add Is current e2e version compatible with stable channel and |
| } | ||
|
|
||
| // TODO(amirh): Remove this hack once androidx.lifecycle is included on stable. https://github.com/flutter/flutter/issues/42348 | ||
| afterEvaluate { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with this temporary tweak, the error you were pointing at should be gone on stable. Would you like to sync your PR up to master and try the tests again?
|
Currently I have no time to work on this PR. Feel free to close or modify it. |
|
v2 embedding has been supported in path provider from #2284. I'm closing this PR |
Description
Migrate android path_provider plugin to the new embedding method.
Related Issues
flutter/flutter#41844
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?