This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[Connectivity] migrate to the new android embedding #2142
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| // Copyright 2019 The Chromium Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| package dev.flutter.plugins.connectivity; | ||
|
|
||
| import io.flutter.embedding.engine.plugins.FlutterPlugin; | ||
| import io.flutter.plugin.common.EventChannel; | ||
| import io.flutter.plugin.common.MethodChannel; | ||
| import io.flutter.plugins.connectivity.ConnectivityMethodChannelHandler; | ||
|
|
||
| public class ConnectivityPlugin implements FlutterPlugin { | ||
|
|
||
| private FlutterPluginBinding pluginBinding; | ||
|
|
||
| @Override | ||
| public void onAttachedToEngine(FlutterPluginBinding binding) { | ||
| this.pluginBinding = binding; | ||
|
||
| final MethodChannel channel = | ||
| new MethodChannel( | ||
| pluginBinding.getFlutterEngine().getDartExecutor(), "plugins.flutter.io/connectivity"); | ||
| final EventChannel eventChannel = | ||
| new EventChannel( | ||
| pluginBinding.getFlutterEngine().getDartExecutor(), | ||
| "plugins.flutter.io/connectivity_status"); | ||
|
|
||
| ConnectivityMethodChannelHandler handler = | ||
| new ConnectivityMethodChannelHandler(pluginBinding.getApplicationContext()); | ||
|
|
||
| channel.setMethodCallHandler(handler); | ||
| eventChannel.setStreamHandler(handler); | ||
| } | ||
|
|
||
| @Override | ||
| public void onDetachedFromEngine(FlutterPluginBinding binding) { | ||
| this.pluginBinding = null; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| package io.flutter.plugins.connectivity; | ||
|
|
||
| import android.content.BroadcastReceiver; | ||
| import android.content.Context; | ||
| import android.content.Intent; | ||
| import android.content.IntentFilter; | ||
| import android.net.ConnectivityManager; | ||
| import android.net.Network; | ||
| import android.net.NetworkCapabilities; | ||
| import android.net.NetworkInfo; | ||
| import android.net.wifi.WifiInfo; | ||
| import android.net.wifi.WifiManager; | ||
| import android.os.Build; | ||
| import io.flutter.plugin.common.EventChannel; | ||
| import io.flutter.plugin.common.MethodCall; | ||
| import io.flutter.plugin.common.MethodChannel; | ||
|
|
||
| public class ConnectivityMethodChannelHandler | ||
| implements MethodChannel.MethodCallHandler, EventChannel.StreamHandler { | ||
|
|
||
| private final Context context; | ||
| private ConnectivityManager manager; | ||
| private BroadcastReceiver receiver; | ||
|
|
||
| public ConnectivityMethodChannelHandler(Context context) { | ||
|
||
| assert (context != null); | ||
| this.context = context; | ||
| this.manager = | ||
| (ConnectivityManager) | ||
| context.getApplicationContext().getSystemService(Context.CONNECTIVITY_SERVICE); | ||
| } | ||
|
|
||
| @Override | ||
| public void onListen(Object arguments, EventChannel.EventSink events) { | ||
|
||
| context.registerReceiver(receiver, new IntentFilter(ConnectivityManager.CONNECTIVITY_ACTION)); | ||
| } | ||
|
|
||
| @Override | ||
| public void onCancel(Object arguments) { | ||
| context.unregisterReceiver(receiver); | ||
| receiver = null; | ||
| } | ||
|
|
||
| @Override | ||
| public void onMethodCall(MethodCall call, MethodChannel.Result result) { | ||
|
Contributor
There was a problem hiding this comment. Would you mind adding unit tests for this class to ensure that incoming messages are correctly parsed, and outgoing messages are correctly serialized?
Contributor
There was a problem hiding this comment. I think that Dart e2e integration tests would be acceptable as an alternative to unit tests. |
||
| switch (call.method) { | ||
| case "check": | ||
| handleCheck(call, result); | ||
| break; | ||
| case "wifiName": | ||
| handleWifiName(call, result); | ||
| break; | ||
| case "wifiBSSID": | ||
| handleBSSID(call, result); | ||
| break; | ||
| case "wifiIPAddress": | ||
| handleWifiIPAddress(call, result); | ||
| break; | ||
| default: | ||
| result.notImplemented(); | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| private String getNetworkType(ConnectivityManager manager) { | ||
| if (android.os.Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) { | ||
| Network network = manager.getActiveNetwork(); | ||
| NetworkCapabilities capabilities = manager.getNetworkCapabilities(network); | ||
| if (capabilities == null) { | ||
| return "none"; | ||
| } | ||
| if (capabilities.hasTransport(NetworkCapabilities.TRANSPORT_WIFI) | ||
| || capabilities.hasTransport(NetworkCapabilities.TRANSPORT_ETHERNET)) { | ||
| return "wifi"; | ||
| } | ||
| if (capabilities.hasTransport(NetworkCapabilities.TRANSPORT_CELLULAR)) { | ||
| return "mobile"; | ||
| } | ||
| } | ||
|
|
||
| return getNetworkTypeLegacy(manager); | ||
| } | ||
|
|
||
| @SuppressWarnings("deprecation") | ||
| private String getNetworkTypeLegacy(ConnectivityManager manager) { | ||
| // handle type for Android versions less than Android 9 | ||
| NetworkInfo info = manager.getActiveNetworkInfo(); | ||
| if (info == null || !info.isConnected()) { | ||
| return "none"; | ||
| } | ||
| int type = info.getType(); | ||
| switch (type) { | ||
| case ConnectivityManager.TYPE_ETHERNET: | ||
| case ConnectivityManager.TYPE_WIFI: | ||
| case ConnectivityManager.TYPE_WIMAX: | ||
| return "wifi"; | ||
| case ConnectivityManager.TYPE_MOBILE: | ||
| case ConnectivityManager.TYPE_MOBILE_DUN: | ||
| case ConnectivityManager.TYPE_MOBILE_HIPRI: | ||
| return "mobile"; | ||
| default: | ||
| return "none"; | ||
| } | ||
| } | ||
|
|
||
| private BroadcastReceiver createReceiver(final EventChannel.EventSink events) { | ||
|
||
| return new BroadcastReceiver() { | ||
| @Override | ||
| public void onReceive(Context context, Intent intent) { | ||
| events.success(checkNetworkType()); | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| private String checkNetworkType() { | ||
| return getNetworkType(manager); | ||
| } | ||
|
|
||
| private void handleCheck(MethodCall call, final MethodChannel.Result result) { | ||
| result.success(checkNetworkType()); | ||
| } | ||
|
|
||
| private WifiInfo getWifiInfo() { | ||
| WifiManager wifiManager = | ||
| (WifiManager) context.getApplicationContext().getSystemService(Context.WIFI_SERVICE); | ||
| return wifiManager == null ? null : wifiManager.getConnectionInfo(); | ||
| } | ||
|
|
||
| private void handleWifiName(MethodCall call, final MethodChannel.Result result) { | ||
| WifiInfo wifiInfo = getWifiInfo(); | ||
| String ssid = null; | ||
| if (wifiInfo != null) ssid = wifiInfo.getSSID(); | ||
| if (ssid != null) ssid = ssid.replaceAll("\"", ""); // Android returns "SSID" | ||
| result.success(ssid); | ||
| } | ||
|
|
||
| private void handleBSSID(MethodCall call, MethodChannel.Result result) { | ||
| WifiInfo wifiInfo = getWifiInfo(); | ||
| String bssid = null; | ||
| if (wifiInfo != null) bssid = wifiInfo.getBSSID(); | ||
| result.success(bssid); | ||
| } | ||
|
|
||
| private void handleWifiIPAddress(MethodCall call, final MethodChannel.Result result) { | ||
| WifiManager wifiManager = | ||
|
||
| (WifiManager) context.getApplicationContext().getSystemService(Context.WIFI_SERVICE); | ||
|
|
||
| WifiInfo wifiInfo = null; | ||
| if (wifiManager != null) wifiInfo = wifiManager.getConnectionInfo(); | ||
|
|
||
| String ip = null; | ||
| int i_ip = 0; | ||
| if (wifiInfo != null) i_ip = wifiInfo.getIpAddress(); | ||
|
|
||
| if (i_ip != 0) | ||
| ip = | ||
| String.format( | ||
| "%d.%d.%d.%d", | ||
| (i_ip & 0xff), (i_ip >> 8 & 0xff), (i_ip >> 16 & 0xff), (i_ip >> 24 & 0xff)); | ||
|
|
||
| result.success(ip); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind add Javadocs to all public, non-trivial classes/methods/fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New classes members/methods added should definitely be added with Javadocs.
Regarding all existing code - this is definitely tech debt we should be paying, and is welcomed if the author is interested in doing it as part of this PR, though it shouldn't block it. For the purpose of supporting the v2 embedder in all plugins I suggest we focus PRs and reviews on that goal. Please do leave any improvement suggestions of existing code as non-blocking nits.
I think this fits with the spirit of the Flutter code review guidelines: