Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Update and migrate iOS examples projects #2086

Closed
jmagman wants to merge 2 commits into from
Closed

Update and migrate iOS examples projects #2086

jmagman wants to merge 2 commits into from

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Sep 24, 2019 •
edited
Loading

Description

  1. Let Move flutter_assets to App.framework flutter#26630 flutter_assets migrator run
  2. Run pod install so flutter_assets is removed from the asset copy build phase
  3. Migrate deprecated "English" to "en" language
  4. Remove the occasional DEVELOPMENT_TEAM references since having those provisioning profiles should not be required to run the examples (most examples don't have one)
  5. Allow Xcode to remove extraneous xcconfigs, see Remove xcconfigs from template Copy Bundle Resources build phases flutter#38724
  6. Remove extraneous framework outputs Multiple commands produce '/build/ios/Debug-iphonesimulator/Runner.app/Frameworks/Flutter.framework flutter#20685
  7. Let Xcode 11 update build settings

Related Issues

Get to a buildable baseline so I can start working on flutter/flutter#41007.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Does just changing the example app actually require pubspec version bumps or CHANGELOG updates?

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@jmagman jmagman self-assigned this Sep 24, 2019
jmagman
jmagman commented Sep 24, 2019
View reviewed changes
packages/sensors/example/ios/Runner.xcodeproj/project.pbxproj
isa = XCBuildConfiguration;
baseConfigurationReference = 9740EEB21CF90195004384FC /* Debug.xcconfig */;
buildSettings = {
ARCHS = arm64;
Copy link
Member Author

@jmagman jmagman Sep 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused a compilation error.

jmagman
jmagman commented Sep 24, 2019
View reviewed changes
packages/share/example/ios/Runner.xcodeproj/project.pbxproj
isa = XCBuildConfiguration;
baseConfigurationReference = 9740EEB21CF90195004384FC /* Debug.xcconfig */;
buildSettings = {
ARCHS = arm64;
Copy link
Member Author

@jmagman jmagman Sep 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused a compilation error.

@jmagman
Copy link
Member Author

jmagman commented Sep 25, 2019

Breaking this large PR down by plugin. Closing.

@jmagman jmagman closed this Sep 25, 2019
@jmagman jmagman deleted the build-examples branch October 1, 2019 01:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jmagman jmagman

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @googlebot