Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@NiKoTron
Copy link

@NiKoTron NiKoTron commented Sep 24, 2019

Precache file to a temp directory for ios13, to prevent unvalidated URL into the response.

Description

Since URL could be invalidated if image picker delegate is deallocated. It's copied a picked file to the temporary directory and returns it.

Related Issues

*On iOS13 device, pickVideo does not work.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Precache file to a temp directory for ios13, to prevent unvalidated URL into the response.
@NiKoTron NiKoTron requested a review from cyanglaz as a code owner September 24, 2019 09:01
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@NiKoTron
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ailic88
Copy link

ailic88 commented Oct 3, 2019

@NiKoTron @cyanglaz please be aware that this fix introduce a new issue when source is camera(not gallery).

@cyanglaz
Copy link
Contributor

@NiKoTron #2083 seems solving the same issue in a similar way? Do you mind take a review on #2083 and we can close this PR?

@cyanglaz cyanglaz self-assigned this Oct 14, 2019
@NiKoTron
Copy link
Author

@cyanglaz Yep, #2083 uses a similar way. I don't mind if you close my PR.

@cyanglaz
Copy link
Contributor

@NiKoTron Thank you. Closing.

@cyanglaz cyanglaz closed this Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants