This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[video_player] [iOS] : Fix an issue where video_player plugin can cause a crash on iPhone X running iOS 12 when disposing the video controller #2079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When popping a page that contains a video on it, and disposing of the video controller in the dispose method could very often cause a crash on an iPhoneX running iOS 12. This happens because the DisplayLink has notified the flutter Texture registry that a frame is ready, and the flutter GPU thread then tries to get the pixel buffer after the FLTVideoPlayer object has been destructed.
Related Issues
flutter/flutter#41125
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?